From 25462ef55fb5e71fe5604bcd06ee984101d2c3ed Mon Sep 17 00:00:00 2001
From: bgrebennikov <bgrebennikovv@gmail.com>
Date: Sun, 10 Apr 2022 18:40:48 +0400
Subject: [PATCH 1/3] Remove old unusable code

---
 .idea/workspace.xml                           |  33 ++----
 .../main/res/layout/fragment_idea_details.xml | 102 ------------------
 2 files changed, 11 insertions(+), 124 deletions(-)

diff --git a/.idea/workspace.xml b/.idea/workspace.xml
index a0e0fd8..6d22113 100644
--- a/.idea/workspace.xml
+++ b/.idea/workspace.xml
@@ -14,28 +14,9 @@
     <option name="autoReloadType" value="NONE" />
   </component>
   <component name="ChangeListManager">
-    <list default="true" id="178febb5-0f2f-46e0-832a-2c4941d73985" name="Default Changelist" comment="Redesign of Idea Details Fragment">
-      <change afterPath="$PROJECT_DIR$/app/src/main/java/com/github/bgrebennikov/devbuff/common/extensions/AppBarExtension.kt" afterDir="false" />
-      <change afterPath="$PROJECT_DIR$/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/customViews/AppbarIdeaDetails.kt" afterDir="false" />
-      <change afterPath="$PROJECT_DIR$/app/src/main/res/layout/appbar_idea_details.xml" afterDir="false" />
-      <change afterPath="$PROJECT_DIR$/app/src/main/res/values/attrs.xml" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/.gradle/7.2/executionHistory/executionHistory.bin" beforeDir="false" afterPath="$PROJECT_DIR$/.gradle/7.2/executionHistory/executionHistory.bin" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/.gradle/7.2/executionHistory/executionHistory.lock" beforeDir="false" afterPath="$PROJECT_DIR$/.gradle/7.2/executionHistory/executionHistory.lock" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/.gradle/7.2/fileHashes/fileHashes.bin" beforeDir="false" afterPath="$PROJECT_DIR$/.gradle/7.2/fileHashes/fileHashes.bin" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/.gradle/7.2/fileHashes/fileHashes.lock" beforeDir="false" afterPath="$PROJECT_DIR$/.gradle/7.2/fileHashes/fileHashes.lock" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/.gradle/7.2/fileHashes/resourceHashesCache.bin" beforeDir="false" afterPath="$PROJECT_DIR$/.gradle/7.2/fileHashes/resourceHashesCache.bin" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/.gradle/buildOutputCleanup/buildOutputCleanup.lock" beforeDir="false" afterPath="$PROJECT_DIR$/.gradle/buildOutputCleanup/buildOutputCleanup.lock" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/.gradle/buildOutputCleanup/outputFiles.bin" beforeDir="false" afterPath="$PROJECT_DIR$/.gradle/buildOutputCleanup/outputFiles.bin" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/.idea/misc.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/misc.xml" afterDir="false" />
+    <list default="true" id="178febb5-0f2f-46e0-832a-2c4941d73985" name="Default Changelist" comment="Idea Details AppBar as Custom View">
       <change beforePath="$PROJECT_DIR$/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/workspace.xml" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/adapters/binding/ProfileBindingAdapter.kt" beforeDir="false" afterPath="$PROJECT_DIR$/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/adapters/binding/ProfileBindingAdapter.kt" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/fragments/IdeaDetailsFragment.kt" beforeDir="false" afterPath="$PROJECT_DIR$/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/fragments/IdeaDetailsFragment.kt" afterDir="false" />
       <change beforePath="$PROJECT_DIR$/app/src/main/res/layout/fragment_idea_details.xml" beforeDir="false" afterPath="$PROJECT_DIR$/app/src/main/res/layout/fragment_idea_details.xml" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/app/src/main/res/xml/fragment_idea_details_xml_constraintlayout3_scene.xml" beforeDir="false" />
-      <change beforePath="$PROJECT_DIR$/app/src/main/res/xml/fragment_idea_details_xml_constraintlayout3_scene2.xml" beforeDir="false" />
-      <change beforePath="$PROJECT_DIR$/app/src/main/res/xml/fragment_idea_details_xml_constraintlayout3_scene3.xml" beforeDir="false" />
-      <change beforePath="$PROJECT_DIR$/app/src/main/res/xml/fragment_idea_details_xml_constraintlayout3_scene4.xml" beforeDir="false" />
-      <change beforePath="$PROJECT_DIR$/app/src/main/res/xml/fragment_idea_details_xml_ideaheader_scene.xml" beforeDir="false" />
     </list>
     <option name="SHOW_DIALOG" value="false" />
     <option name="HIGHLIGHT_CONFLICTS" value="true" />
@@ -425,7 +406,14 @@
       <option name="project" value="LOCAL" />
       <updated>1649327566267</updated>
     </task>
-    <option name="localTasksCounter" value="11" />
+    <task id="LOCAL-00011" summary="Idea Details AppBar as Custom View">
+      <created>1649600646145</created>
+      <option name="number" value="00011" />
+      <option name="presentableId" value="LOCAL-00011" />
+      <option name="project" value="LOCAL" />
+      <updated>1649600646145</updated>
+    </task>
+    <option name="localTasksCounter" value="12" />
     <servers />
   </component>
   <component name="Vcs.Log.History.Properties">
@@ -509,6 +497,7 @@
     <MESSAGE value="initial commit" />
     <MESSAGE value="Initial Commit" />
     <MESSAGE value="Redesign of Idea Details Fragment" />
-    <option name="LAST_COMMIT_MESSAGE" value="Redesign of Idea Details Fragment" />
+    <MESSAGE value="Idea Details AppBar as Custom View" />
+    <option name="LAST_COMMIT_MESSAGE" value="Idea Details AppBar as Custom View" />
   </component>
 </project>
\ No newline at end of file
diff --git a/app/src/main/res/layout/fragment_idea_details.xml b/app/src/main/res/layout/fragment_idea_details.xml
index fac57c9..22fc4c6 100644
--- a/app/src/main/res/layout/fragment_idea_details.xml
+++ b/app/src/main/res/layout/fragment_idea_details.xml
@@ -45,108 +45,6 @@
             tools:subtitle="Boris Azazovsky"
             tools:title="Reaction Alpha" />
 
-
-<!--        <androidx.constraintlayout.widget.ConstraintLayout-->
-<!--            android:id="@+id/appBar"-->
-<!--            android:layout_width="match_parent"-->
-<!--            android:layout_height="?attr/actionBarSize"-->
-<!--            android:alpha="0"-->
-<!--            android:background="@color/white"-->
-<!--            android:padding="@dimen/margin_small"-->
-<!--            app:layout_constraintTop_toTopOf="parent">-->
-
-<!--            <ImageView-->
-<!--                android:id="@+id/backIcon"-->
-<!--                android:layout_width="wrap_content"-->
-<!--                android:layout_height="0dp"-->
-<!--                android:layout_marginStart="@dimen/margin_default"-->
-<!--                android:adjustViewBounds="true"-->
-<!--                android:clickable="true"-->
-<!--                android:focusable="true"-->
-<!--                android:foreground="?attr/selectableItemBackground"-->
-<!--                android:padding="@dimen/padding_small"-->
-<!--                android:src="@drawable/ic_back"-->
-<!--                app:layout_constraintBottom_toBottomOf="parent"-->
-<!--                app:layout_constraintDimensionRatio="1:1"-->
-<!--                app:layout_constraintStart_toStartOf="parent"-->
-<!--                app:layout_constraintTop_toTopOf="parent"-->
-<!--                android:background="@drawable/bg_rounded_24"-->
-<!--                app:tint="@color/black"-->
-<!--                android:contentDescription="@string/cd_author_avatar_default"-->
-<!--                />-->
-
-<!--            <androidx.cardview.widget.CardView-->
-<!--                android:id="@+id/userAvatar"-->
-<!--                android:layout_width="wrap_content"-->
-<!--                android:layout_height="match_parent"-->
-<!--                android:layout_marginStart="@dimen/margin_default"-->
-<!--                android:layout_marginTop="@dimen/margin_small"-->
-<!--                android:layout_marginBottom="@dimen/margin_small"-->
-<!--                android:clickable="true"-->
-<!--                android:focusable="true"-->
-<!--                android:foreground="?attr/selectableItemBackground"-->
-<!--                app:cardCornerRadius="@dimen/corners_radius_small"-->
-<!--                app:layout_constraintBottom_toBottomOf="parent"-->
-<!--                app:layout_constraintDimensionRatio="1:1"-->
-<!--                app:layout_constraintStart_toEndOf="@+id/backIcon"-->
-<!--                app:layout_constraintTop_toTopOf="parent"-->
-<!--                app:cardElevation="0dp"-->
-<!--                >-->
-
-<!--                <ImageView-->
-<!--                    android:id="@+id/userAvatarImage"-->
-<!--                    android:layout_width="match_parent"-->
-<!--                    android:layout_height="wrap_content"-->
-<!--                    android:adjustViewBounds="true"-->
-<!--                    android:scaleType="centerCrop"-->
-<!--                    tools:src="@raw/sample_image"-->
-<!--                    app:ideaThumbnailPhotoFromUser="@{alreadyLoadedInfo.ownerIdea.id}"-->
-<!--                    />-->
-<!--            </androidx.cardview.widget.CardView>-->
-
-<!--            <LinearLayout-->
-<!--                android:id="@+id/toolbarTitle"-->
-<!--                android:layout_width="0dp"-->
-<!--                android:layout_height="0dp"-->
-<!--                android:layout_marginStart="@dimen/margin_default"-->
-<!--                android:gravity="center_vertical"-->
-<!--                android:orientation="vertical"-->
-<!--                app:layout_constraintBottom_toBottomOf="parent"-->
-<!--                app:layout_constraintEnd_toStartOf="@+id/toolbarStatus"-->
-<!--                app:layout_constraintStart_toEndOf="@+id/userAvatar"-->
-<!--                app:layout_constraintTop_toTopOf="parent">-->
-
-<!--                <TextView-->
-<!--                    android:layout_width="wrap_content"-->
-<!--                    android:layout_height="wrap_content"-->
-<!--                    android:text="@{alreadyLoadedInfo.name}"-->
-<!--                    android:textColor="@color/black"-->
-<!--                    tools:text="@string/default_idea_title" />-->
-
-<!--                <TextView-->
-<!--                    android:layout_width="wrap_content"-->
-<!--                    android:layout_height="wrap_content"-->
-<!--                    android:text="@string/default_name" />-->
-
-
-<!--            </LinearLayout>-->
-
-<!--            <ImageView-->
-<!--                android:id="@+id/toolbarStatus"-->
-<!--                android:layout_width="wrap_content"-->
-<!--                android:layout_height="0dp"-->
-<!--                android:layout_marginStart="@dimen/margin_default"-->
-<!--                android:layout_marginEnd="@dimen/margin_default"-->
-<!--                android:src="@drawable/ic_waiting_for_team"-->
-<!--                app:layout_constraintBottom_toBottomOf="parent"-->
-<!--                app:layout_constraintDimensionRatio="1:1"-->
-<!--                app:layout_constraintEnd_toEndOf="parent"-->
-<!--                app:layout_constraintStart_toEndOf="@+id/toolbarTitle"-->
-<!--                app:layout_constraintTop_toTopOf="parent" />-->
-
-
-<!--        </androidx.constraintlayout.widget.ConstraintLayout>-->
-
         <TextView
             android:id="@+id/updateDate"
             android:layout_width="wrap_content"

From 0e91c17d3fd18a2fe3b31c2bcdc7254d9e422d25 Mon Sep 17 00:00:00 2001
From: bgrebennikov <bgrebennikovv@gmail.com>
Date: Sun, 10 Apr 2022 18:42:01 +0400
Subject: [PATCH 2/3] rename motion scene for idea details fragment

---
 app/src/main/res/layout/fragment_idea_details.xml               | 2 +-
 ...ntlayout3_scene5.xml => fragment_idea_details_xml_scene.xml} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename app/src/main/res/xml/{fragment_idea_details_xml_constraintlayout3_scene5.xml => fragment_idea_details_xml_scene.xml} (100%)

diff --git a/app/src/main/res/layout/fragment_idea_details.xml b/app/src/main/res/layout/fragment_idea_details.xml
index 22fc4c6..ae3f701 100644
--- a/app/src/main/res/layout/fragment_idea_details.xml
+++ b/app/src/main/res/layout/fragment_idea_details.xml
@@ -23,7 +23,7 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:background="@color/white"
-        app:layoutDescription="@xml/fragment_idea_details_xml_constraintlayout3_scene5"
+        app:layoutDescription="@xml/fragment_idea_details_xml_scene"
         tools:context=".presentation.ui.fragments.IdeaDetailsFragment">
 
         <View
diff --git a/app/src/main/res/xml/fragment_idea_details_xml_constraintlayout3_scene5.xml b/app/src/main/res/xml/fragment_idea_details_xml_scene.xml
similarity index 100%
rename from app/src/main/res/xml/fragment_idea_details_xml_constraintlayout3_scene5.xml
rename to app/src/main/res/xml/fragment_idea_details_xml_scene.xml

From 3ccbd913cefec4696ecff4ee53c606e7a3f16aed Mon Sep 17 00:00:00 2001
From: bgrebennikov <bgrebennikovv@gmail.com>
Date: Mon, 11 Apr 2022 16:02:10 +0400
Subject: [PATCH 3/3] Optimize Idea Details Appbar

---
 .idea/workspace.xml                           |  2 +-
 .../ui/customViews/AppbarIdeaDetails.kt       | 46 ++++++++++++-------
 2 files changed, 30 insertions(+), 18 deletions(-)

diff --git a/.idea/workspace.xml b/.idea/workspace.xml
index 6d22113..2985535 100644
--- a/.idea/workspace.xml
+++ b/.idea/workspace.xml
@@ -16,7 +16,7 @@
   <component name="ChangeListManager">
     <list default="true" id="178febb5-0f2f-46e0-832a-2c4941d73985" name="Default Changelist" comment="Idea Details AppBar as Custom View">
       <change beforePath="$PROJECT_DIR$/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/workspace.xml" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/app/src/main/res/layout/fragment_idea_details.xml" beforeDir="false" afterPath="$PROJECT_DIR$/app/src/main/res/layout/fragment_idea_details.xml" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/customViews/AppbarIdeaDetails.kt" beforeDir="false" afterPath="$PROJECT_DIR$/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/customViews/AppbarIdeaDetails.kt" afterDir="false" />
     </list>
     <option name="SHOW_DIALOG" value="false" />
     <option name="HIGHLIGHT_CONFLICTS" value="true" />
diff --git a/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/customViews/AppbarIdeaDetails.kt b/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/customViews/AppbarIdeaDetails.kt
index d382669..2c09fb0 100644
--- a/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/customViews/AppbarIdeaDetails.kt
+++ b/app/src/main/java/com/github/bgrebennikov/devbuff/presentation/ui/customViews/AppbarIdeaDetails.kt
@@ -4,6 +4,7 @@ import android.content.Context
 import android.content.res.TypedArray
 import android.util.AttributeSet
 import android.view.LayoutInflater
+import android.view.View
 import androidx.constraintlayout.widget.ConstraintLayout
 import com.bumptech.glide.Glide
 import com.bumptech.glide.load.resource.drawable.DrawableTransitionOptions.withCrossFade
@@ -15,17 +16,11 @@ class AppbarIdeaDetails @JvmOverloads constructor(
     context: Context, attrs: AttributeSet? = null
 ) : ConstraintLayout(context, attrs) {
 
-    private val binding by lazy {
-        AppbarIdeaDetailsBinding.bind(
-            LayoutInflater.from(context)
-                .inflate(
-                    R.layout.appbar_idea_details,
-                    this, true
-                )
-        )
-    }
+    private var _binding: AppbarIdeaDetailsBinding? = null
+    val binding get() = _binding!!
+
 
-    private val viewAttrs: TypedArray by lazy{
+    private val viewAttrs: TypedArray by lazy {
         context.obtainStyledAttributes(
             attrs,
             R.styleable.AppbarIdeaDetails,
@@ -33,15 +28,25 @@ class AppbarIdeaDetails @JvmOverloads constructor(
         )
     }
 
-    init{
+    init {
+
+        _binding = AppbarIdeaDetailsBinding.bind(
+            LayoutInflater.from(context)
+                .inflate(
+                    R.layout.appbar_idea_details,
+                    this,
+                    true
+                )
+        )
+
         setupAppBar()
     }
 
-    fun onBackPressed(callback: () -> Unit){
+    fun onBackPressed(callback: () -> Unit) {
         binding.backIcon.setOnClickListener { callback.invoke() }
     }
 
-    fun setImageFromUserId(userId: String?){
+    fun setImageFromUserId(userId: String?) {
 
         if (userId == null) return
 
@@ -58,17 +63,16 @@ class AppbarIdeaDetails @JvmOverloads constructor(
 
     }
 
-    fun setTitle(title: String?){
+    fun setTitle(title: String?) {
         binding.title.text = title
     }
 
-    fun setSubtitle(subtitle: String?){
+    fun setSubtitle(subtitle: String?) {
         binding.subtitle.text = subtitle
     }
 
 
-
-    private fun setupAppBar(){
+    private fun setupAppBar() {
         binding.apply {
             setTitle(viewAttrs.getString(R.styleable.AppbarIdeaDetails_title))
             setSubtitle(viewAttrs.getString(R.styleable.AppbarIdeaDetails_subtitle))
@@ -76,4 +80,12 @@ class AppbarIdeaDetails @JvmOverloads constructor(
         }
     }
 
+    override fun onDetachedFromWindow() {
+        super.onDetachedFromWindow()
+        Glide.with(context).clear(binding.userAvatarImage)
+        _binding = null
+
+
+    }
+
 }
\ No newline at end of file