Fix ResourceWarning: unclosed file in setup.py and test_cli.py

BoboTiG · bbc2 · commit 569e131f383c · 2019-01-06T09:41:44.000+01:00
Signed-off-by: Mickaël Schoentgen &lt;contact@tiger-222.fr&gt;
diff --git a/setup.py b/setup.py
@@ -14,7 +14,8 @@
         long_description = f.read()
 
 meta = {}
-exec(open('./dotenv/version.py').read(), meta)
+with open('./dotenv/version.py') as f:
+    exec(f.read(), meta)
 
 setup(
     name="python-dotenv",
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -199,7 +199,8 @@ def test_get_key_with_interpolation(dotenv_file):
     dotenv.set_key(dotenv_file, 'FOO', '${HELLO}')
     dotenv.set_key(dotenv_file, 'BAR', 'CONCATENATED_${HELLO}_POSIX_VAR')
 
-    lines = list(open(dotenv_file, "r").readlines())
+    with open(dotenv_file) as f:
+        lines = f.readlines()
     assert lines == [
         'HELLO="WORLD"\n',
         'FOO="${HELLO}"\n',
