Merge pull request voxpupuli#180 from petems/add_facter_spec_tests

shivapoudel · shivapoudel · commit 1f35f5c44875 · 2015-03-19T20:14:09.000+05:45
Add facter unit tests for version facts
diff --git a/lib/facter/pip_version.rb b/lib/facter/pip_version.rb
@@ -18,7 +18,7 @@
   has_weight 100
   setcode do
     if Facter::Util::Resolution.which('pip')
-      Facter::Util::Resolution.exec('pip --version 2>/dev/null').match(/^pip (\d+\.\d+\.?\d*).*$/)[1]
+      Facter::Util::Resolution.exec('pip --version 2>&1').match(/^pip (\d+\.\d+\.?\d*).*$/)[1]
     end
   end
 end
diff --git a/lib/facter/virtualenv_version.rb b/lib/facter/virtualenv_version.rb
@@ -18,7 +18,7 @@
   has_weight 100
   setcode do
     if Facter::Util::Resolution.which('virtualenv')
-      Facter::Util::Resolution.exec('virtualenv --version 2>&1')
+      Facter::Util::Resolution.exec('virtualenv --version 2>&1').match(/^(\d+\.\d+\.?\d*).*$/)[0]
     end
   end
 end
diff --git a/spec/unit/facter/pip_version_spec.rb b/spec/unit/facter/pip_version_spec.rb
@@ -0,0 +1,32 @@
+require "spec_helper"
+
+describe Facter::Util::Fact do
+  before {
+    Facter.clear
+  }
+
+  let(:pip_version_output) { <<-EOS
+pip 6.0.6 from /opt/boxen/homebrew/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pip-6.0.6-py2.7.egg (python 2.7)
+EOS
+  }
+
+  describe "pip_version" do
+    context 'returns pip version when pip present' do
+      it do
+        Facter::Util::Resolution.stubs(:exec)
+        Facter::Util::Resolution.expects(:which).with("pip").returns(true)
+        Facter::Util::Resolution.expects(:exec).with("pip --version 2>&1").returns(pip_version_output)
+        Facter.value(:pip_version).should == "6.0.6"
+      end
+    end
+
+    context 'returns nil when pip not present' do
+      it do
+        Facter::Util::Resolution.stubs(:exec)
+        Facter::Util::Resolution.expects(:which).with("pip").returns(false)
+        Facter.value(:pip_version).should == nil
+      end
+    end
+
+  end
+end
diff --git a/spec/unit/facter/python_version_spec.rb b/spec/unit/facter/python_version_spec.rb
@@ -0,0 +1,32 @@
+require "spec_helper"
+
+describe Facter::Util::Fact do
+  before {
+    Facter.clear
+  }
+
+  let(:python_version_output) { <<-EOS
+Python 2.7.9
+EOS
+  }
+
+  describe "python_version" do
+    context 'returns python version when python present' do
+      it do
+        Facter::Util::Resolution.stubs(:exec)
+        Facter::Util::Resolution.expects(:which).with("python").returns(true)
+        Facter::Util::Resolution.expects(:exec).with("python -V 2>&1").returns(python_version_output)
+        Facter.value(:python_version).should == "2.7.9"
+      end
+    end
+
+    context 'returns nil when python not present' do
+      it do
+        Facter::Util::Resolution.stubs(:exec)
+        Facter::Util::Resolution.expects(:which).with("python").returns(false)
+        Facter.value(:python_version).should == nil
+      end
+    end
+
+  end
+end
diff --git a/spec/unit/facter/virtualenv_version_spec.rb b/spec/unit/facter/virtualenv_version_spec.rb
@@ -0,0 +1,32 @@
+require "spec_helper"
+
+describe Facter::Util::Fact do
+  before {
+    Facter.clear
+  }
+
+  let(:virtualenv_version_output) { <<-EOS
+12.0.7
+EOS
+  }
+
+  describe "virtualenv_version" do
+    context 'returns virtualenv version when virtualenv present' do
+      it do
+        Facter::Util::Resolution.stubs(:exec)
+        Facter::Util::Resolution.expects(:which).with("virtualenv").returns(true)
+        Facter::Util::Resolution.expects(:exec).with("virtualenv --version 2>&1").returns(virtualenv_version_output)
+        Facter.value(:virtualenv_version).should == "12.0.7"
+      end
+    end
+
+    context 'returns nil when virtualenv not present' do
+      it do
+        Facter::Util::Resolution.stubs(:exec)
+        Facter::Util::Resolution.expects(:which).with("virtualenv").returns(false)
+        Facter.value(:virtualenv_version).should == nil
+      end
+    end
+
+  end
+end
