🧪 Add test for check_error (#42)

rnovatorov · google-labs-jules[bot] · web-flow · commit eded498a76ea · 2026-04-01T14:44:38.000+02:00
* 🧪 Add test for check_error

Added comprehensive unit tests for the `enapter.http.api.errors.check_error` function. Covered all logical branches, including successful responses, generic server errors (non-JSON payloads triggering raise_for_status), and API-specific errors (single and multiple errors from DTO). Also added coverage for empty payloads parsing.

Co-authored-by: rnovatorov &lt;20299819+rnovatorov@users.noreply.github.com&gt;

* 🎨 Fix black formatting in test_errors.py

Ran `black tests/unit/test_http/test_api/test_errors.py` to fix formatting violations that were causing the CI `make check` step to fail. Now lines involving `httpx.Response` object creation are properly wrapped to respect the line length limit.

Co-authored-by: rnovatorov &lt;20299819+rnovatorov@users.noreply.github.com&gt;

* 🧪 Add test verifying `check_error` reads response body

Addresses PR feedback by adding `test_check_error_reads_body` which verifies that `response.aread()` is called when `response.is_success` is False, ensuring the body is completely read for streamed responses. Also fixed PEP8 import order.

Co-authored-by: rnovatorov &lt;20299819+rnovatorov@users.noreply.github.com&gt;

---------

Co-authored-by: google-labs-jules[bot] &lt;161369871+google-labs-jules[bot]@users.noreply.github.com&gt;
diff --git a/tests/unit/test_http/test_api/test_errors.py b/tests/unit/test_http/test_api/test_errors.py
@@ -0,0 +1,99 @@
+from unittest.mock import AsyncMock
+
+import httpx
+import pytest
+
+from enapter.http.api.errors import Error, MultiError, check_error
+
+
+@pytest.mark.asyncio
+async def test_check_error_success():
+    """Test that check_error does nothing when response is successful."""
+    response = httpx.Response(
+        status_code=200, request=httpx.Request("GET", "https://example.com")
+    )
+    await check_error(response)
+
+
+@pytest.mark.asyncio
+async def test_check_error_non_json():
+    """Test that check_error calls raise_for_status when response is not JSON."""
+    response = httpx.Response(
+        status_code=500,
+        content=b"Internal Server Error",
+        request=httpx.Request("GET", "https://example.com"),
+    )
+    with pytest.raises(httpx.HTTPStatusError):
+        await check_error(response)
+
+
+@pytest.mark.asyncio
+async def test_check_error_api_error_single():
+    """Test that check_error raises a single Error when one is present in DTO."""
+    dto = {
+        "errors": [
+            {
+                "message": "Device not found",
+                "code": "DEVICE_NOT_FOUND",
+                "details": {"device_id": "test_device"},
+            }
+        ]
+    }
+    response = httpx.Response(
+        status_code=404, json=dto, request=httpx.Request("GET", "https://example.com")
+    )
+    with pytest.raises(Error) as exc_info:
+        await check_error(response)
+
+    assert exc_info.value.message == "Device not found"
+    assert exc_info.value.code == "DEVICE_NOT_FOUND"
+    assert exc_info.value.details == {"device_id": "test_device"}
+
+
+@pytest.mark.asyncio
+async def test_check_error_api_error_multiple():
+    """Test that check_error raises MultiError when multiple are present in DTO."""
+    dto = {
+        "errors": [
+            {"message": "Invalid parameter A", "code": "INVALID_PARAM"},
+            {"message": "Invalid parameter B", "code": "INVALID_PARAM"},
+        ]
+    }
+    response = httpx.Response(
+        status_code=400, json=dto, request=httpx.Request("GET", "https://example.com")
+    )
+    with pytest.raises(MultiError) as exc_info:
+        await check_error(response)
+
+    assert len(exc_info.value.errors) == 2
+    assert exc_info.value.errors[0].message == "Invalid parameter A"
+    assert exc_info.value.errors[1].message == "Invalid parameter B"
+
+
+def test_error_from_dto_empty():
+    """Test Error.from_dto with minimal fields."""
+    err = Error.from_dto({})
+    assert err.message == "<no message>"
+    assert err.code is None
+    assert err.details is None
+
+
+def test_multi_error_from_dto_empty_list():
+    """Test MultiError.from_dto raises ValueError on empty error list."""
+    with pytest.raises(ValueError, match="empty error list"):
+        MultiError.from_dto({"errors": []})
+
+
+@pytest.mark.asyncio
+async def test_check_error_reads_body():
+    """Test that check_error reads the response body."""
+    response = httpx.Response(
+        status_code=500,
+        content=b"Internal Server Error",
+        request=httpx.Request("GET", "https://example.com"),
+    )
+    response.aread = AsyncMock()
+    with pytest.raises(httpx.HTTPStatusError):
+        await check_error(response)
+
+    response.aread.assert_awaited_once()
