fix: pass getServiceDefinitions() to createAllServicesEnabledMap in buildAllServicesEnabledMap

Copilot · PDowney · web-flow · commit 028e887aca6f · 2026-04-11T19:37:48.000Z
Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/439610d5-824a-4207-8e5e-99786b5e0675 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ Changes are organized by date, with the most recent changes listed first.
 
 ## 2026-04-11
 
+### 🐛 BUG FIX: EXTERNAL SERVICES FALLBACK MAP
+
+- Fixed `buildAllServicesEnabledMap()` in `external-services.js` to pass `this.getServiceDefinitions()` to `createAllServicesEnabledMap()`; the missing argument caused `Object.keys(undefined)` → `TypeError` in both API-failure fallback branches of `fetchAvailableServices()`, meaning the UI could never recover gracefully from a failed or empty config API response.
+
 ### 🔧 CODE QUALITY: REMOVE UNREACHABLE CODE IN EXTERNAL SERVICES
 
 - Removed unreachable dead code in `buildAllServicesEnabledMap()` in `external-services.js`; the five lines following `return this.createAllServicesEnabledMap()` (a stale `services` object build-up that also referenced an undefined `serviceDefinitions` variable) could never execute and have been deleted.
diff --git a/config/var/www/admin/control-panel/external-services/external-services.js b/config/var/www/admin/control-panel/external-services/external-services.js
@@ -391,7 +391,7 @@ export class ExternalServicesManager {
    * @returns {Object} Services object with every known key set to true
    */
   buildAllServicesEnabledMap() {
-    return this.createAllServicesEnabledMap();
+    return this.createAllServicesEnabledMap(this.getServiceDefinitions());
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,7 @@ export class ExternalServicesManager {`
`391`	`391`	`* @returns {Object} Services object with every known key set to true`
`392`	`392`	`*/`
`393`	`393`	`buildAllServicesEnabledMap() {`
`394`		`- return this.createAllServicesEnabledMap();`
	`394`	`+ return this.createAllServicesEnabledMap(this.getServiceDefinitions());`
`395`	`395`	`}`
`396`	`396`
`397`	`397`	`/**`