fix: replace window.localStorage with globalThis.localStorage to resolve prefer-globalThis lint warnings

Copilot · PDowney · web-flow · commit 117bc2b38875 · 2026-04-11T20:54:37.000Z
Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/30bea704-71fb-41ba-85b0-a3741ac7829b Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,8 @@ Changes are organized by date, with the most recent changes listed first.
 
 ### 🔧 EXTERNAL SERVICES CONTROL PANEL IMPROVEMENTS
 
+- Replaced all `window.localStorage` references in `external-services.js` with `globalThis.localStorage` to satisfy the `prefer-globalThis` lint rule and improve cross-environment compatibility.
+
 - Improved `handleSavePreferences` in `external-services.js` to distinguish between localStorage being unavailable/disabled versus storage being full: a separate availability pre-check now throws `'browser storage is unavailable or disabled'`, while quota-exceeded errors (`QuotaExceededError`, `NS_ERROR_DOM_QUOTA_REACHED`, error code 22/1014) now throw `'browser storage is full'`.
 - Added request deduplication to `fetchServiceData` via a lazily-initialised `inFlightRequests` map: concurrent calls for the same uncached service key now share a single in-flight Promise rather than queuing separate fetch operations.
 - Refactored `loadServicePreferences` to use flat, sequential try-catch blocks instead of nested ones, eliminating the outer catch that could mask the distinction between localStorage access failures and JSON parse failures.
diff --git a/config/var/www/admin/control-panel/external-services/external-services.js b/config/var/www/admin/control-panel/external-services/external-services.js
@@ -758,15 +758,15 @@ export class ExternalServicesManager {
       // Save preferences to local storage (avoid tamper-prone cookie storage)
       const storageTestKey = '__servicePreferences_storage_test__';
       try {
-        window.localStorage.setItem(storageTestKey, '1');
-        window.localStorage.removeItem(storageTestKey);
+        globalThis.localStorage.setItem(storageTestKey, '1');
+        globalThis.localStorage.removeItem(storageTestKey);
       } catch (availabilityError) {
         console.error('localStorage availability check failed:', availabilityError);
         throw new Error('Unable to save preferences: browser storage is unavailable or disabled.');
       }
 
       try {
-        window.localStorage.setItem('servicePreferences', JSON.stringify(currentPreferences));
+        globalThis.localStorage.setItem('servicePreferences', JSON.stringify(currentPreferences));
       } catch (storageError) {
         const isQuotaExceeded = storageError && (
           storageError.name === 'QuotaExceededError' ||
@@ -1345,7 +1345,7 @@ export class ExternalServicesManager {
     // Try to load from local storage
     let storedPrefs = null;
     try {
-      storedPrefs = window.localStorage.getItem('servicePreferences');
+      storedPrefs = globalThis.localStorage.getItem('servicePreferences');
     } catch (storageError) {
       console.error('Failed to access localStorage for service preferences:', storageError);
       return null;
@@ -1367,7 +1367,7 @@ export class ExternalServicesManager {
       console.warn('Corrupted service preferences detected; resetting stored preferences to defaults.');
       // Clear invalid entry
       try {
-        window.localStorage.removeItem('servicePreferences');
+        globalThis.localStorage.removeItem('servicePreferences');
       } catch (removeError) {
         console.error('Failed to clear invalid stored preferences:', removeError);
       }
