Improve error handling for Maldet installation

PDowney · web-flow · commit 2f496b695f7a · 2026-04-11T04:46:12.000-04:00
Enhanced error handling during Maldet installation process.
diff --git a/scripts/install/tools/security/maldet.sh b/scripts/install/tools/security/maldet.sh
@@ -20,8 +20,15 @@ source /usr/local/bin/enginescript/scripts/functions/shared/enginescript-common.
 
 # Maldet Install
 cd /usr/local/src || { echo "Error: Failed to change to /usr/local/src" >&2; exit 1; }
-download_and_extract "https://www.rfxn.com/downloads/maldetect-current.tar.gz" "/usr/local/src/maldetect-current.tar.gz" "/usr/local/src"
-cd /usr/local/src/maldetect-*/ || { echo "Error: Failed to locate extracted maldetect directory in /usr/local/src" >&2; exit 1; }
+download_and_extract "https://www.rfxn.com/downloads/maldetect-current.tar.gz" "/usr/local/src/maldetect-current.tar.gz" "/usr/local/src" || { echo "Error: Failed to download and extract Maldet from https://www.rfxn.com/downloads/maldetect-current.tar.gz" >&2; exit 1; }
+shopt -s nullglob
+maldet_dirs=(/usr/local/src/maldetect-*/)
+shopt -u nullglob
+if [ "${#maldet_dirs[@]}" -ne 1 ]; then
+    echo "Error: Expected exactly one extracted maldetect directory in /usr/local/src, found ${#maldet_dirs[@]}" >&2
+    exit 1
+fi
+cd "${maldet_dirs[0]}/" || { echo "Error: Failed to change to extracted maldetect directory" >&2; exit 1; }
 ./install.sh || { echo "Error: Maldet installation failed while running install.sh" >&2; exit 1; }
 echo "/sys" >> /usr/local/maldetect/ignore_paths || { echo "Error: Failed to update maldetect ignore_paths" >&2; exit 1; }
 
