fix: improve CI run-install-step.sh error handling for log directory and tail failures

Copilot · PDowney · web-flow · commit 32c5c6b1678a · 2026-04-10T20:23:58.000Z
Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/251c9f84-fbb7-4e12-8638-03958c4819d7 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,13 @@ Changes are organized by date, with the most recent changes listed first.
 
 ## 2026-04-10
 
+### 🔧 CI RUN-INSTALL-STEP ERROR HANDLING IMPROVEMENTS
+
+- Enhanced log directory validation in `scripts/ci/run-install-step.sh` to separately check for non-existent directories (`[ ! -d ]`) and inaccessible directories (`[ ! -x ]`) before attempting to resolve the path, providing more specific error messages instead of a single combined error.
+- Updated the fallback error message when `tail` fails to capture and display the actual error output from `tail`, making it easier to debug why log file contents could not be displayed.
+
+
+
 ### 🔧 EXTERNAL SERVICES JS CODE QUALITY IMPROVEMENTS
 
 - Extracted the duplicated category order list in `external-services.js` into a single module-level `CATEGORY_ORDER` constant shared by `getCategoryOrder()` and `getServiceOrder()`, eliminating the risk of inconsistencies when categories are added or changed.
diff --git a/scripts/ci/run-install-step.sh b/scripts/ci/run-install-step.sh
@@ -43,10 +43,21 @@ esac
 ALLOWED_LOG_BASE_DIR="$(pwd -P)"
 LOG_PARENT_DIR="$(dirname -- "$LOG_PATH")"
 LOG_FILENAME="$(basename -- "$LOG_PATH")"
+
+if [ ! -d "$LOG_PARENT_DIR" ]; then
+  echo "Error: log directory does not exist: $LOG_PARENT_DIR" >&2
+  exit 1
+fi
+
+if [ ! -x "$LOG_PARENT_DIR" ]; then
+  echo "Error: log directory is not accessible (missing execute permission): $LOG_PARENT_DIR" >&2
+  exit 1
+fi
+
 RESOLVED_LOG_PARENT="$(cd "$LOG_PARENT_DIR" 2>/dev/null && pwd -P)"
 
 if [ -z "${RESOLVED_LOG_PARENT:-}" ]; then
-  echo "Error: log directory does not exist or is not accessible: $LOG_PARENT_DIR" >&2
+  echo "Error: unable to resolve log directory path: $LOG_PARENT_DIR" >&2
   exit 1
 fi
 
@@ -113,7 +124,14 @@ if [ "$SCRIPT_EXIT_CODE" -ne 0 ]; then
   fi
   echo "Script end time: $(date)" >> "$LOG_PATH"
   echo "Last 50 lines of output:"
-  tail -50 "$LOG_PATH" || echo "Failed to display log file contents: $LOG_PATH"
+  TAIL_OUTPUT="$(tail -50 "$LOG_PATH" 2>&1)"
+  TAIL_EXIT_CODE=$?
+  if [ "$TAIL_EXIT_CODE" -eq 0 ]; then
+    echo "$TAIL_OUTPUT"
+  else
+    echo "Failed to display log file contents: $LOG_PATH"
+    echo "tail error: $TAIL_OUTPUT"
+  fi
 
   exit 1
 fi
