fix: exit with error when memory cannot be determined instead of 1024 MB fallback

Copilot · PDowney · Copilot · commit 4453c3faab81 · 2026-04-01T01:34:55.000Z
Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/cdd9b3a8-a9d8-4d72-9e36-f65ab2d7f3bf Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,13 @@ All notable changes to EngineScript will be documented in this file.
 
 Changes are organized by date, with the most recent changes listed first.
 
+## 2026-04-01
+
+### 🐛 PHP CONFIG UPDATE SCRIPT HARDENING
+
+- **Added `AVAILABLE_MEMORY` validation** in `scripts/update/php-config-update.sh`. If `/proc/meminfo` is unavailable or `awk` returns an empty/non-numeric value, the script now falls back to `MemTotal`, and if that also fails, exits with an error rather than proceeding with an unknown memory value.
+- **Added error checking for `cp -f` operations** in `scripts/update/php-config-update.sh`. The three config file copy operations (`php.ini`, `php-fpm.conf`, `www.conf`) now use `if ! cp -f ...` to detect failures and exit with an error message rather than silently continuing with a broken or missing configuration.
+
 ## 2026-03-27
 
 ### 🐛 DEBUG MODE ADDED TO ALL INSTALL AND UPDATE SCRIPTS
diff --git a/scripts/update/php-config-update.sh b/scripts/update/php-config-update.sh
@@ -23,13 +23,13 @@ calculate_php() {
   # No fallbacks needed as this script will be run on a system with a modern kernel.
   # MemAvailable field will be present in /proc/meminfo on modern kernels and is the most accurate representation of available memory for applications.
   AVAILABLE_MEMORY=$(awk '/MemAvailable/ {printf "%d", $2/1024}' /proc/meminfo)
-  # Validate that AVAILABLE_MEMORY is a non-empty numeric value; fall back conservatively if not.
+  # Validate that AVAILABLE_MEMORY is a non-empty numeric value; exit if it cannot be determined.
   if ! [[ "${AVAILABLE_MEMORY}" =~ ^[0-9]+$ ]]; then
-    # Fallback: use MemTotal if available, otherwise default to 1024 MB.
+    # Fallback: use MemTotal if available, otherwise exit with an error.
     AVAILABLE_MEMORY=$(awk '/MemTotal/ {printf "%d", $2/1024}' /proc/meminfo 2>/dev/null || echo "")
     if ! [[ "${AVAILABLE_MEMORY}" =~ ^[0-9]+$ ]]; then
-      echo "Warning: Unable to determine available memory from /proc/meminfo; using conservative default of 1024 MB." >&2
-      AVAILABLE_MEMORY=1024
+      echo "Error: Unable to determine available memory from /proc/meminfo; cannot continue." >&2
+      exit 1
     fi
   fi
   AVERAGE_PHP_MEMORY_REQ_MB=80  # average PHP memory requirement in MB
