Address code review: trim category name in value branch and explicit length check

Copilot · PDowney · web-flow · commit 71b91c8a28f5 · 2026-04-10T22:11:30.000Z
Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/d05756ba-edf7-4e3a-91a5-471a65796ca2 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
diff --git a/config/var/www/admin/control-panel/external-services/external-services.js b/config/var/www/admin/control-panel/external-services/external-services.js
@@ -1311,7 +1311,7 @@ export class ExternalServicesManager {
     serviceKeys.forEach((key) => {
       const definition = SERVICE_DEFINITIONS[key] || {};
       const category = typeof definition.category === 'string' && definition.category.trim()
-        ? definition.category
+        ? definition.category.trim()
         : 'Uncategorized';
 
       if (!servicesByCategory.has(category)) {
@@ -1325,7 +1325,7 @@ export class ExternalServicesManager {
     // First: known categories in configured display order.
     CATEGORY_ORDER.forEach((category) => {
       const keys = servicesByCategory.get(category);
-      if (keys && keys.length) {
+      if (keys && keys.length > 0) {
         ordered.push(...keys.sort((a, b) => a.localeCompare(b)));
         servicesByCategory.delete(category);
       }
