Fix admin control panel install: add FONTAWESOME_VER comment and fix adminer sed range

Copilot · PDowney · Copilot · commit 8dcb7a94b187 · 2026-03-20T20:33:52.000Z
Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com> Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/d1324dd1-545e-4334-b8d6-122069e95038
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,13 @@ All notable changes to EngineScript will be documented in this file.
 
 Changes are organized by date, with the most recent changes listed first.
 
+## 2026-03-20
+
+### 🔧 ADMIN CONTROL PANEL INSTALL SCRIPT FIXES
+
+- **Added explanatory comment** in `scripts/install/tools/frontend/admin-control-panel-install.sh` clarifying that the `{FONTAWESOME_VER}` placeholder only appears in `index.html`, so its substitution is intentionally scoped to that file rather than included in the multi-file loop.
+- **Fixed sed range command** used to remove the Adminer tool card (`adminer-tool` div) when `INSTALL_ADMINER=0`. Changed `{1d;$d;}` to `d` so the command deletes all lines in the matching range, not only the first and last lines of the range.
+
 ## 2026-03-03
 
 ### 🌐 NON-WORDPRESS DOMAIN SUPPORT (Tasks 113 & 114)
diff --git a/scripts/install/tools/frontend/admin-control-panel-install.sh b/scripts/install/tools/frontend/admin-control-panel-install.sh
@@ -28,6 +28,8 @@ mkdir -p /var/www/admin/control-panel
 cp -a /usr/local/bin/enginescript/config/var/www/admin/control-panel/. /var/www/admin/control-panel/
 
 # Substitute frontend dependency versions
+# Note: The Font Awesome version placeholder {FONTAWESOME_VER} is only used in index.html,
+# so we only need to substitute it in that file.
 sed -i "s|{FONTAWESOME_VER}|${FONTAWESOME_VER}|g" /var/www/admin/control-panel/index.html
 for file in index.html dashboard.js external-services/external-services.js; do
     sed -i "s|{ES_DASHBOARD_VER}|${ES_DASHBOARD_VER}|g" "/var/www/admin/control-panel/${file}"
@@ -40,7 +42,7 @@ if [[ "${INSTALL_ADMINER}" -eq 0 ]]; then
     #   - the opening <div> with id="adminer-tool" and its matching closing </div> must each be on a single line
     #   - the block must not contain nested <div> elements whose closing tags appear before the end of the card
     # If this structure changes, update this command (or switch to an HTML-aware tool) to avoid partial removal.
-    sed -i '/<div[^>]*id="adminer-tool"[^>]*>/,/<\/div>/{1d;$d;}' "/var/www/admin/control-panel/index.html"
+    sed -i '/<div[^>]*id="adminer-tool"[^>]*>/,/<\/div>/d' "/var/www/admin/control-panel/index.html"
 fi
 
 # Set permissions for the EngineScript frontend
