Improving permissions code

PDowney · PDowney · commit b65b6f4987dd · 2021-10-11T17:21:48.000-04:00
diff --git a/scripts/install/php/php-install.sh b/scripts/install/php/php-install.sh
@@ -47,18 +47,12 @@ touch /var/log/php/fpm-php.www.log
 touch /var/log/php/php.log
 
 chmod 775 /var/cache/opcache
-chmod 775 /var/log/opcache
-chmod 775 /var/log/php
-chmod 775 /var/log/opcache/opcache.log
-chmod 775 /var/log/php/fpm-php.www.log
-chmod 775 /var/log/php/php.log
+find /var/log/php -type d,f -exec chmod 755 {} \;
+find /var/log/opcache -type d,f -exec chmod 755 {} \;
 
 chown -hR www-data:www-data /var/cache/opcache
 chown -hR www-data:www-data /var/log/opcache
 chown -hR www-data:www-data /var/log/php
-chown -hR www-data:www-data /var/log/opcache/opcache.log
-chown -hR www-data:www-data /var/log/php/fpm-php.www.log
-chown -hR www-data:www-data /var/log/php/php.log
 
 # Restart PHP
 service php${PHP_VER}-fpm restart
diff --git a/scripts/install/redis/redis-install.sh b/scripts/install/redis/redis-install.sh
@@ -31,11 +31,11 @@ apt install redis-server redis-tools --no-install-recommends
 mkdir -p /run/redis
 mkdir -p /var/log/redis
 touch /var/log/redis/redis.log
-chmod 775 /var/log/redis/redis.log
+find /var/log/redis -type d,f -exec chmod 755 {} \;
 chmod 775 /etc/redis/redis.conf
 chmod 775 /run/redis
 chown -hR redis:redis /run/redis
-chown -hR redis:redis /var/log/redis/redis.log
+chown -hR redis:redis /var/log/redis
 
 cp -p /usr/local/bin/enginescript/etc/redis/redis.conf /etc/redis/redis.conf
 sed -i "s|SEDREDISMAXMEM|${SERVER_MEMORY_TOTAL_07}|g" /etc/redis/redis.conf
diff --git a/scripts/install/tools/mysql/phpmyadmin.sh b/scripts/install/tools/mysql/phpmyadmin.sh
@@ -31,7 +31,7 @@ mv phpMyAdmin-${PHPMYADMIN_VER}-all-languages phpmyadmin
 mv phpmyadmin /var/www/admin/enginescript
 sed -e "s|cfg\['blowfish_secret'\] = ''|cfg\['blowfish_secret'\] = '$RAND_CHAR32'|" /var/www/admin/enginescript/phpmyadmin/config.sample.inc.php > /var/www/admin/enginescript/phpmyadmin/config.inc.php
 mkdir -p /var/www/admin/enginescript/phpmyadmin/tmp
-chown -hR www-data:www-data /var/www/admin/enginescript/phpmyadmin/tmp
+chown -hR www-data:www-data /var/www/admin/enginescript/phpmyadmin
 mysql -u root -p$MARIADB_ADMIN_PASSWORD < /var/www/admin/enginescript/phpmyadmin/sql/create_tables.sql
 mysql -u root -p$MARIADB_ADMIN_PASSWORD -e "CREATE USER 'pma'@'localhost' IDENTIFIED BY 'pmapass';"
 mysql -u root -p$MARIADB_ADMIN_PASSWORD -e "GRANT ALL PRIVILEGES ON phpmyadmin.* TO 'pma'@'localhost' WITH GRANT OPTION; FLUSH PRIVILEGES;"
