fix: add explicit realpath error handling and simplify tail failure branch in run-install-step.sh

Copilot · PDowney · web-flow · commit c82335dd330e · 2026-04-10T21:07:58.000Z
Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/ce151db2-a5fb-4c0f-b712-4f25546a58c1 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,14 @@ Changes are organized by date, with the most recent changes listed first.
 
 ## 2026-04-10
 
+### 🔧 CI RUN-INSTALL-STEP ERROR HANDLING IMPROVEMENTS
+
+- Added explicit error handling for `realpath` when resolving `ALLOWED_INSTALL_DIR` in `scripts/ci/run-install-step.sh`; the script now exits with a descriptive message if the directory is not found or not resolvable instead of silently failing.
+- Added explicit error handling for `realpath` when resolving `ALLOWED_LOG_BASE_DIR`; the script now exits with a descriptive message if the current working directory path cannot be resolved.
+- Simplified the `tail` failure branch in the log-display logic: removed the redundant second `tail` read (which would fail for the same reason as the first) and replaced it with a plain exit-code message.
+
+## 2026-04-10
+
 ### 🐛 VHOST IMPORT LOGGING / EXTRACTION FLOW FIXES
 
 - Removed a duplicate WordPress extraction block in `scripts/functions/vhost/vhost-import.sh` that re-ran archive extraction and wp-config path detection after those steps had already completed.
diff --git a/scripts/ci/run-install-step.sh b/scripts/ci/run-install-step.sh
@@ -12,7 +12,10 @@ TIMEOUT_SECONDS="$2"
 INSTALL_SCRIPT_PATH="$3"
 LOG_PATH="$4"
 INTEGER_REGEX='^[0-9]+$'
-ALLOWED_INSTALL_DIR="$(realpath "$(pwd)/scripts/ci")"
+if ! ALLOWED_INSTALL_DIR="$(realpath "$(pwd)/scripts/ci" 2>/dev/null)"; then
+  echo "Error: allowed install directory not found or not resolvable: $(pwd)/scripts/ci" >&2
+  exit 1
+fi
 CANONICAL_INSTALL_SCRIPT_PATH=""
 # `timeout` returns 124 when the wrapped command times out.
 TIMEOUT_EXIT_CODE=124
@@ -40,7 +43,10 @@ case "$CANONICAL_INSTALL_SCRIPT_PATH" in
     ;;
 esac
 
-ALLOWED_LOG_BASE_DIR="$(realpath "$(pwd)")"
+if ! ALLOWED_LOG_BASE_DIR="$(realpath "$(pwd)" 2>/dev/null)"; then
+  echo "Error: unable to resolve current working directory path" >&2
+  exit 1
+fi
 LOG_PARENT_DIR="$(dirname -- "$LOG_PATH")"
 LOG_FILENAME="$(basename -- "$LOG_PATH")"
 
@@ -129,9 +135,7 @@ if [ "$SCRIPT_EXIT_CODE" -ne 0 ]; then
     echo "$TAIL_OUTPUT"
   else
     echo "Failed to display log file contents: $LOG_PATH"
-    TAIL_ERROR_OUTPUT="$(tail -50 "$LOG_PATH" 2>&1 >/dev/null || true)"
-    SANITIZED_TAIL_ERROR="$(printf '%s' "$TAIL_ERROR_OUTPUT" | tr '\n' ' ' | tr -cd '[:print:]\t ')"
-    echo "tail error: ${SANITIZED_TAIL_ERROR:-unable to read log output}"
+    echo "tail failed with exit code: $TAIL_EXIT_CODE"
   fi
 
   exit 1
