vhost-import: add explicit return statements to satisfy SonarCloud warnings

Copilot · PDowney · web-flow · commit f2bf419f9205 · 2026-04-11T00:20:09.000Z
Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/4e797a46-9887-4f1f-bcaf-187ebe5e3ff7 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,14 @@ All notable changes to EngineScript will be documented in this file.
 
 Changes are organized by date, with the most recent changes listed first.
 
+## 2026-04-11
+
+### 🔧 VHOST IMPORT SONARCLOUD WARNING FIXES
+
+- Added explicit `return 0` at the end of `build_default_url_validation_regex()` in `scripts/functions/vhost/vhost-import.sh` to satisfy SonarCloud explicit-return rule.
+- Added explicit `return $?` at the end of `is_directory_absent_or_empty()` in `scripts/functions/vhost/vhost-import.sh` to satisfy SonarCloud explicit-return rule.
+- Added explicit `return 0` at the end of `escape_ere_literal_for_sed()` in `scripts/functions/vhost/vhost-import.sh` to satisfy SonarCloud explicit-return rule.
+
 ## 2026-04-10 (2)
 
 ### 🔒 VHOST IMPORT SECURITY AND MAINTAINABILITY IMPROVEMENTS
diff --git a/scripts/functions/vhost/vhost-import.sh b/scripts/functions/vhost/vhost-import.sh
@@ -44,6 +44,7 @@ build_default_url_validation_regex() {
   local suffix='([/?#].*)?'
 
   echo "^${scheme}${host}${port}${suffix}$"
+  return 0
 }
 
 readonly DEFAULT_URL_VALIDATION_REGEX="$(build_default_url_validation_regex)"
@@ -69,6 +70,7 @@ validate_zip_archive_paths() {
 is_directory_absent_or_empty() {
     local dir="$1"
     [[ ! -d "$dir" ]] || [[ -z "$(find "$dir" -mindepth 1 -print -quit)" ]]
+    return $?
 }
 
 # --- Instructions for Preparing Files ---
@@ -132,6 +134,7 @@ sleep 1
 escape_ere_literal_for_sed() {
     local raw="$1"
     printf '%s' "$raw" | sed -E 's#[][(){}.^$*+?|\\/-]#\\&#g'
+    return 0
 }
 
 # Function to extract define values (Handles single/double quotes)

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ build_default_url_validation_regex() {`
`44`	`44`	`local suffix='([/?#].*)?'`
`45`	`45`
`46`	`46`	`echo "^${scheme}${host}${port}${suffix}$"`
	`47`	`+ return 0`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`readonly DEFAULT_URL_VALIDATION_REGEX="$(build_default_url_validation_regex)"`
`@@ -69,6 +70,7 @@ validate_zip_archive_paths() {`
`69`	`70`	`is_directory_absent_or_empty() {`
`70`	`71`	`local dir="$1"`
`71`	`72`	`[[ ! -d "$dir" ]] \|\| [[ -z "$(find "$dir" -mindepth 1 -print -quit)" ]]`
	`73`	`+ return $?`
`72`	`74`	`}`
`73`	`75`
`74`	`76`	`# --- Instructions for Preparing Files ---`
`@@ -132,6 +134,7 @@ sleep 1`
`132`	`134`	`escape_ere_literal_for_sed() {`
`133`	`135`	`local raw="$1"`
`134`	`136`	`printf '%s' "$raw" \| sed -E 's#[][(){}.^$*+?\|\\/-]#\\&#g'`
	`137`	`+ return 0`
`135`	`138`	`}`
`136`	`139`
`137`	`140`	`# Function to extract define values (Handles single/double quotes)`