Fixes

PDowney · web-flow · commit fa5ec0693e88 · 2025-11-22T16:24:41.000-05:00
diff --git a/config/var/www/admin/control-panel/external-services/external-services-api.php b/config/var/www/admin/control-panel/external-services/external-services-api.php
@@ -143,21 +143,27 @@ function parseStatusFeed($feedUrl, $filter = null) {
             // Check for resolved/completed keywords which indicate the incident is over
             $isResolved = preg_match('/\b(resolved|completed|fixed|closed|ended|restored|operational)\b/i', $title);
             
+            // If not recent or if resolved, no incident
             if (!$isRecent || $isResolved) {
-                // No active incident
-                $status['indicator'] = 'none';
-                $status['description'] = 'All Systems Operational';
+                return [
+                    'indicator' => 'none',
+                    'description' => 'All Systems Operational'
+                ];
             }
+            
+            // Check severity of active incident
             if (preg_match('/outage|down|major|critical|offline/i', $fullText)) {
-                // Active incident detected - check severity
-                $status['indicator'] = 'major';
-                $status['description'] = 'Major Outage';
-            }
-            if ($isRecent && !$isResolved && !preg_match('/outage|down|major|critical|offline/i', $fullText)) {
-                // Any other active incident is considered minor
-                $status['indicator'] = 'minor';
-                $status['description'] = 'Partially Degraded Service';
+                return [
+                    'indicator' => 'major',
+                    'description' => 'Major Outage'
+                ];
             }
+            
+            // Any other active incident is considered minor
+            return [
+                'indicator' => 'minor',
+                'description' => 'Partially Degraded Service'
+            ];
         }
         // Check if it's an RSS feed
         elseif (isset($xml->channel->item)) {
@@ -199,26 +205,27 @@ function parseStatusFeed($feedUrl, $filter = null) {
             // Check for resolved/completed keywords which indicate the incident is over
             $isResolved = preg_match('/\b(resolved|completed|fixed|closed|ended|restored|operational)\b/i', $title);
             
+            // If not recent or if resolved, no incident
             if (!$isRecent || $isResolved) {
-                // No active incident
-                $status['indicator'] = 'none';
-                $status['description'] = 'All Systems Operational';
+                return [
+                    'indicator' => 'none',
+                    'description' => 'All Systems Operational'
+                ];
             }
+            
+            // Check severity of active incident
             if (preg_match('/outage|down|major|critical|offline/i', $fullText)) {
-                // Active incident detected - check severity
-                $status['indicator'] = 'major';
-                $status['description'] = 'Major Outage';
+                return [
+                    'indicator' => 'major',
+                    'description' => 'Major Outage'
+                ];
             }
-            if ($isRecent && !$isResolved && !preg_match('/outage|down|major|critical|offline/i', $fullText)) {
-                // Any other active incident is considered minor
-                $status['indicator'] = 'minor';
-                $status['description'] = 'Partially Degraded Service';
-            }
-        }
-        
-        // Truncate long descriptions
-        if (strlen($status['description']) > 200) {
-            $status['description'] = substr($status['description'], 0, 197) . '...';
+            
+            // Any other active incident is considered minor
+            return [
+                'indicator' => 'minor',
+                'description' => 'Partially Degraded Service'
+            ];
         }
         
         return $status;
diff --git a/config/var/www/admin/control-panel/external-services/external-services.js b/config/var/www/admin/control-panel/external-services/external-services.js
@@ -447,6 +447,8 @@ export class ExternalServicesManager {
     statusSpan.appendChild(contentNode);
     
     const serviceLink = this.createBaseServiceCard(serviceKey, serviceDef, "static", headerDiv);
+    // Add success status class for green border like operational services
+    serviceLink.classList.add('status-success');
     container.appendChild(serviceLink);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -447,6 +447,8 @@ export class ExternalServicesManager {`
`447`	`447`	`statusSpan.appendChild(contentNode);`
`448`	`448`
`449`	`449`	`const serviceLink = this.createBaseServiceCard(serviceKey, serviceDef, "static", headerDiv);`
	`450`	`+ // Add success status class for green border like operational services`
	`451`	`+ serviceLink.classList.add('status-success');`
`450`	`452`	`container.appendChild(serviceLink);`
`451`	`453`	`}`
`452`	`454`