CI: document timeout exit code constant and handle tee failure after successful install

Copilot · PDowney · web-flow · commit fbb5133eb842 · 2026-04-10T19:58:18.000Z
Agent-Logs-Url: https://github.com/EngineScript/EngineScript/sessions/54538003-bd42-4247-8202-8781e8642546 Co-authored-by: PDowney <11467177+PDowney@users.noreply.github.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,13 @@ All notable changes to EngineScript will be documented in this file.
 
 Changes are organized by date, with the most recent changes listed first.
 
+## 2026-04-10 (2)
+
+### 🔧 CI RUN-INSTALL-STEP IMPROVEMENTS
+
+- Defined `TIMEOUT_EXIT_CODE=124` as a named constant with an explanatory comment in `scripts/ci/run-install-step.sh`, replacing the undocumented magic number in the timeout exit-code comparison.
+- Added a `TEE_EXIT_CODE` failure check after a successful installation: if `tee` exits non-zero the script now reports that log streaming failed and exits with code 1, ensuring incomplete logs are surfaced.
+
 ## 2026-04-10
 
 ### 🐛 VHOST IMPORT EXTRACTION FLOW FIX
diff --git a/scripts/ci/run-install-step.sh b/scripts/ci/run-install-step.sh
@@ -12,6 +12,8 @@ TIMEOUT_SECONDS="$2"
 INSTALL_SCRIPT_PATH="$3"
 LOG_PATH="$4"
 INTEGER_REGEX='^[0-9]+$'
+# `timeout` returns 124 when the wrapped command times out.
+TIMEOUT_EXIT_CODE=124
 
 if ! [[ "$TIMEOUT_SECONDS" =~ $INTEGER_REGEX ]]; then
   echo "Error: timeout must be an integer (seconds): $TIMEOUT_SECONDS" >&2
@@ -41,7 +43,7 @@ TEE_EXIT_CODE="${PIPE_EXIT_CODES[1]}"
 set -e
 
 if [ "$SCRIPT_EXIT_CODE" -ne 0 ]; then
-  if [ "$SCRIPT_EXIT_CODE" -eq 124 ]; then
+  if [ "$SCRIPT_EXIT_CODE" -eq "$TIMEOUT_EXIT_CODE" ]; then
     echo "${COMPONENT_NAME} installation timed out after ${TIMEOUT_SECONDS} seconds"
   else
     echo "${COMPONENT_NAME} installation failed"
@@ -57,6 +59,13 @@ if [ "$SCRIPT_EXIT_CODE" -ne 0 ]; then
   exit 1
 fi
 
+if [ "$TEE_EXIT_CODE" -ne 0 ]; then
+  echo "${COMPONENT_NAME} installation completed, but log streaming failed"
+  echo "Log streaming (tee) exit code: $TEE_EXIT_CODE"
+  echo "Script end time: $(date)" >> "$LOG_PATH"
+  exit 1
+fi
+
 echo "Script end time: $(date)" >> "$LOG_PATH"
 # Ensure installer/log writes are flushed before subsequent CI steps that may read logs
 # or create snapshots/caches; this is intentional despite the small performance cost.
