Add ability to change stack.

piotrmurach · piotrmurach · commit 20833bbddca0 · 2014-08-10T21:32:43.000+01:00
diff --git a/lib/github_api/connection.rb b/lib/github_api/connection.rb
@@ -40,15 +40,11 @@ def caching?
     # Exposes middleware builder to facilitate custom stacks and easy
     # addition of new extensions such as cache adapter.
     #
-    def stack(options = {}, &block)
+    # @api public
+    def stack(options = {})
       @stack ||= begin
         builder_class = defined?(Faraday::RackBuilder) ? Faraday::RackBuilder : Faraday::Builder
-
-        if block_given?
-          builder_class.new(&block)
-        else
-          builder_class.new(&Github.default_middleware(options))
-        end
+        builder_class.new(&Github.default_middleware(options))
       end
     end
 
@@ -58,7 +54,8 @@ def stack(options = {}, &block)
     def connection(api, options = {})
       connection_options = default_options(options)
       clear_cache unless options.empty?
-      connection_options.merge!(builder: stack(options.merge!(api: api)))
+      builder = api.stack ? api.stack : stack(options.merge!(api: api))
+      connection_options.merge!(builder: builder)
       if ENV['DEBUG']
         p "Connection options : \n"
         pp connection_options
