Was not properly testing body, and was not passing state

tlunter · tlunter · commit b2697d8e3181 · 2014-08-07T13:29:19.000-04:00
diff --git a/lib/github_api/client/repos/deployments.rb b/lib/github_api/client/repos/deployments.rb
@@ -13,6 +13,7 @@ class Client::Repos::Deployments < API
     ]
 
     VALID_STATUS_OPTIONS = %w[
+      state
       target_url
       description
     ]
diff --git a/spec/github/client/repos/deployments/create_spec.rb b/spec/github/client/repos/deployments/create_spec.rb
@@ -14,7 +14,7 @@
   }
 
   before {
-    stub_post(request_path).with(params).
+    stub_post(request_path).with(:body => params).
       to_return(:body => body, :status => status,
       :headers => {:content_type => "application/json; charset=utf-8"})
   }
@@ -33,7 +33,7 @@
 
     it "should create resource successfully" do
       subject.create user, repo, params
-      a_post(request_path).with(params).should have_been_made
+      a_post(request_path).with(:body => params).should have_been_made
     end
 
     it "should return the resource" do
diff --git a/spec/github/client/repos/deployments/create_status_spec.rb b/spec/github/client/repos/deployments/create_status_spec.rb
@@ -14,7 +14,7 @@
   }
 
   before {
-    stub_post(request_path).with(params).
+    stub_post(request_path).with(:body => params).
       to_return(:body => body, :status => status,
       :headers => {:content_type => "application/json; charset=utf-8"})
   }
@@ -33,7 +33,7 @@
 
     it "should create resource successfully" do
       subject.create_status user, repo, id, params
-      a_post(request_path).with(params).should have_been_made
+      a_post(request_path).with(:body => params).should have_been_made
     end
 
     it "should return the resource" do

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ class Client::Repos::Deployments < API`
`13`	`13`	`]`
`14`	`14`
`15`	`15`	`VALID_STATUS_OPTIONS = %w[`
	`16`	`+ state`
`16`	`17`	`target_url`
`17`	`18`	`description`
`18`	`19`	`]`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`before {`
`17`		`- stub_post(request_path).with(params).`
	`17`	`+ stub_post(request_path).with(:body => params).`
`18`	`18`	`to_return(:body => body, :status => status,`
`19`	`19`	`:headers => {:content_type => "application/json; charset=utf-8"})`
`20`	`20`	`}`
`@@ -33,7 +33,7 @@`
`33`	`33`
`34`	`34`	`it "should create resource successfully" do`
`35`	`35`	`subject.create user, repo, params`
`36`		`- a_post(request_path).with(params).should have_been_made`
	`36`	`+ a_post(request_path).with(:body => params).should have_been_made`
`37`	`37`	`end`
`38`	`38`
`39`	`39`	`it "should return the resource" do`