add pragmas to supress warnings associated with compiler bugs (#316)

rrsettgast · web-flow · commit 02b426e0baed · 2024-02-09T11:20:23.000-08:00
diff --git a/src/MallocBuffer.hpp b/src/MallocBuffer.hpp
@@ -130,16 +130,14 @@ class MallocBuffer : public bufferManipulation::VoidBuffer
   void reallocate( std::ptrdiff_t const size, MemorySpace const space, std::ptrdiff_t const newCapacity )
   {
     LVARRAY_ERROR_IF_NE( space, MemorySpace::host );
-
-#if (defined(__GNUC__) && (__GNUC__ == 8))
-    // This is a workaround for a GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87544
-    std::size_t constexpr maxSize = (NumericLimits< std::size_t >::max / sizeof( T )) >> 1;
-    std::size_t newSpaceSize = math::min( static_cast< std::size_t >(newCapacity), maxSize ) * sizeof( T );
-#else
     std::size_t newSpaceSize = newCapacity * sizeof( T );
-#endif
+
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Walloc-size-larger-than="
     // TODO: If std::is_trivially_copyable_v< T > then we could use std::realloc.
     T * const newPtr = reinterpret_cast< T * >( std::malloc( newSpaceSize ) );
+#pragma GCC diagnostic pop
+
 
     std::ptrdiff_t const overlapAmount = math::min( newCapacity, size );
     arrayManipulation::uninitializedMove( newPtr, overlapAmount, m_data );
diff --git a/src/arrayManipulation.hpp b/src/arrayManipulation.hpp
@@ -298,7 +298,11 @@ void resize( T * const LVARRAY_RESTRICT ptr,
     if( newSize - size > 0 )
     {
       std::size_t const sizeDiff = integerConversion< std::size_t >( newSize - size );
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
+#pragma GCC diagnostic ignored "-Wstringop-overflow="
       memset( reinterpret_cast< void * >( ptr + size ), 0, ( sizeDiff ) * sizeof( T ) );
+#pragma GCC diagnostic pop
     }
   }
   else

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,11 @@ void resize( T * const LVARRAY_RESTRICT ptr,`
`298`	`298`	`if( newSize - size > 0 )`
`299`	`299`	`{`
`300`	`300`	`std::size_t const sizeDiff = integerConversion< std::size_t >( newSize - size );`
	`301`	`+#pragma GCC diagnostic push`
	`302`	`+#pragma GCC diagnostic ignored "-Warray-bounds"`
	`303`	`+#pragma GCC diagnostic ignored "-Wstringop-overflow="`
`301`	`304`	`memset( reinterpret_cast< void * >( ptr + size ), 0, ( sizeDiff ) * sizeof( T ) );`
	`305`	`+#pragma GCC diagnostic pop`
`302`	`306`	`}`
`303`	`307`	`}`
`304`	`308`	`else`