Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GeraskinDenis/basejava
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: hw5
Choose a base ref
...
head repository: GeraskinDenis/basejava
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 33 files changed
  • 2 contributors

Commits on Feb 12, 2023

  1. Merge pull request #8 from GeraskinDenis/hw4 

    HW4:

AbstractArrayStorageTest
Честно говоря, не вижу никакого смысла получать прямой доступ к членам класса - так обычно не делается. Если элемент сохраняется, то нужно save использовать. Если проверяешь доступность, то get, а не прямым доступом. В этом и смысл - тестируется инкапсулированная функциональность, работает презумпция правильного исполнения. Спорить не буду, если хочется так оставить - на здоровье. Но я не видел ни на одном проекте такой подход (как на индусском, так и на американских)

saveOverflow
Не проверяется ранний бросок исключения. Его нужно отлавливать только тогда, когда сохраняется переполняющий элемент, а не вообще.
    @GeraskinDenis
    GeraskinDenis authored Feb 12, 2023
    Configuration menu
    Copy the full SHA
    228ecf3 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Merge branch 'hw5'

    Geraskin Denis committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    ce5e109 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. HW6: Refactoring

    Geraskin Denis committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    efa891d View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. HW7: Added classes 

    Section.java
SectionType.java
TextSection.java
ListSection.java
OrganizationSection.java
Organization.java
Period.java
ContactType.java
Contact.java
    Geraskin Denis committed May 14, 2023
    Configuration menu
    Copy the full SHA
    23f1ff9 View commit details
    Browse the repository at this point in the history

  2. HW7: Refactoring

    Geraskin Denis committed May 14, 2023
    Configuration menu
    Copy the full SHA
    ebf3400 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. HW7: Refactoring 2

    Geraskin Denis committed May 15, 2023
    Configuration menu
    Copy the full SHA
    253e6d6 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Merge pull request #14 from GeraskinDenis/geraskin.denis 

    HW8: Done!
Merge pull request.
    @GeraskinDenis
    GeraskinDenis authored May 17, 2023
    Configuration menu
    Copy the full SHA
    ea63c52 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. HW8

    Geraskin Denis committed May 19, 2023
    Configuration menu
    Copy the full SHA
    cc8dda0 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. HW8: Refactoring 1

    Geraskin Denis committed May 23, 2023
    Configuration menu
    Copy the full SHA
    14e3b80 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Merge pull request #15 from GeraskinDenis/geraskin.denis 

    HW8
    @GeraskinDenis
    GeraskinDenis authored May 29, 2023
    Configuration menu
    Copy the full SHA
    f2ddd0a View commit details
    Browse the repository at this point in the history
Loading