[eslint config] [base] [breaking] enable import rules:

ljharb · ljharb · commit 6980cce17f83 · 2016-06-20T14:32:19.000-07:00
- `no-named-as-default`
 - `no-named-as-default-member`
 - `no-extraneous-dependencies`
 - `extensions`
diff --git a/packages/eslint-config-airbnb-base/rules/imports.js b/packages/eslint-config-airbnb-base/rules/imports.js
@@ -44,22 +44,19 @@ module.exports = {
 
     // do not allow a default import name to match a named export
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-as-default.md
-    // TODO: enable
-    'import/no-named-as-default': 0,
+    'import/no-named-as-default': 2,
 
     // warn on accessing default export property names that are also named exports
-    // TODO: enable?
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-as-default-member.md
-    'import/no-named-as-default-member': 0,
+    'import/no-named-as-default-member': 2,
 
     // disallow use of jsdoc-marked-deprecated imports
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-deprecated.md
     'import/no-deprecated': 0,
 
     // Forbid the use of extraneous packages
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md
-    // TODO: enable
-    'import/no-extraneous-dependencies': [0, {
+    'import/no-extraneous-dependencies': [2, {
       devDependencies: false,
       optionalDependencies: false,
     }],
@@ -99,8 +96,7 @@ module.exports = {
 
     // Ensure consistent use of file extension within the import path
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md
-    // TODO: enable
-    'import/extensions': [0, 'never'],
+    'import/extensions': [2, 'never'],
 
     // Enforce a convention in module import order
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md
diff --git a/packages/eslint-config-airbnb-base/test/.eslintrc b/packages/eslint-config-airbnb-base/test/.eslintrc
@@ -4,6 +4,9 @@
     // rule
     "no-shadow": 0,
     // tests uses `t` for tape
-    "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}]
+    "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}],
+    "import/no-extraneous-dependencies": [2, {
+      "devDependencies": true
+    }],
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,9 @@`
`4`	`4`	`// rule`
`5`	`5`	`"no-shadow": 0,`
`6`	`6`	// tests uses `t` for tape
`7`		`- "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}]`
	`7`	`+ "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}],`
	`8`	`+ "import/no-extraneous-dependencies": [2, {`
	`9`	`+ "devDependencies": true`
	`10`	`+ }],`
`8`	`11`	`}`
`9`	`12`	`}`