Allow importing devDependencies in tests

lencioni · ljharb · commit 7816731d4dab · 2016-07-05T10:11:18.000-07:00
This rule seems to be giving me errors for some places we have imported
devDependencies in our tests such as tape and eslint. This is actually
okay, so we just need to configure this rule to allow devDependencies
for tests.

While I was at it, I added some whitespace to improve readability and
reduce the likelihood of merge conflicts.
diff --git a/packages/eslint-config-airbnb/test/.eslintrc b/packages/eslint-config-airbnb/test/.eslintrc
@@ -3,7 +3,11 @@
     // disabled because I find it tedious to write tests while following this
     // rule
     "no-shadow": 0,
+
     // tests uses `t` for tape
-    "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}]
+    "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}],
+
+    // tests can import things in devDependencies
+    "import/no-extraneous-dependencies": [2, {"devDependencies": true}]
   }
 }
diff --git a/packages/eslint-config-airbnb/test/test-react-order.js b/packages/eslint-config-airbnb/test/test-react-order.js
@@ -8,8 +8,13 @@ const cli = new CLIEngine({
   useEslintrc: false,
   baseConfig: eslintrc,
 
-  // This rule fails when executing on text.
-  rules: { indent: 0 },
+  rules: {
+    // This rule fails when executing on text.
+    indent: 0,
+
+    // It is okay to import devDependencies in tests.
+    'import/no-extraneous-dependencies': [2, { devDependencies: true }],
+  },
 });
 
 function lint(text) {

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,11 @@`
`3`	`3`	`// disabled because I find it tedious to write tests while following this`
`4`	`4`	`// rule`
`5`	`5`	`"no-shadow": 0,`
	`6`	`+`
`6`	`7`	// tests uses `t` for tape
`7`		`- "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}]`
	`8`	`+ "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}],`
	`9`	`+`
	`10`	`+ // tests can import things in devDependencies`
	`11`	`+ "import/no-extraneous-dependencies": [2, {"devDependencies": true}]`
`8`	`12`	`}`
`9`	`13`	`}`