Address PR comments

Sam Davies · Sam Davies · commit 67e7c384a1b9 · 2017-04-05T14:34:10.000+01:00
diff --git a/lib/github_api/client/orgs/projects.rb b/lib/github_api/client/orgs/projects.rb
@@ -22,9 +22,7 @@ class Client::Orgs::Projects < API
     #
     # @api public
     def list(*args)
-      arguments(args, required: [:org_name]) do
-        permit %w[ state ]
-      end
+      arguments(args, required: [:org_name])
       params = arguments.params
 
       params['options'] = OPTIONS
@@ -49,7 +47,6 @@ def list(*args)
     #  github.repos.create name: 'project-name', body: 'project-body', owner: 'owner-name', repo: 'repo-name'
     def create(*args)
       arguments(args, required: [:org_name]) do
-        permit %w[ body name ]
         assert_required %w[ name ]
       end
       params = arguments.params
diff --git a/lib/github_api/client/projects.rb b/lib/github_api/client/projects.rb
@@ -46,9 +46,7 @@ def get(*args)
     #
     # @api public
     def edit(*args)
-      arguments(args, required: [:id]) do
-        permit %w[ name body state ]
-      end
+      arguments(args, required: [:id])
 
       params = arguments.params
       params['options'] = OPTIONS
diff --git a/lib/github_api/client/repos/projects.rb b/lib/github_api/client/repos/projects.rb
@@ -25,9 +25,7 @@ class Client::Repos::Projects < API
     #
     # @api public
     def list(*args)
-      arguments(args, required: [:owner, :repo]) do
-        permit %w[ state ]
-      end
+      arguments(args, required: [:owner, :repo])
       params = arguments.params
 
       params['options'] = OPTIONS
@@ -52,7 +50,6 @@ def list(*args)
     #  github.repos.create name: 'project-name', body: 'project-body', owner: 'owner-name', repo: 'repo-name'
     def create(*args)
       arguments(args, required: [:owner, :repo]) do
-        permit %w[ body name ]
         assert_required %w[ name ]
       end
       params = arguments.params
diff --git a/spec/github/client/repos/projects/create_spec.rb b/spec/github/client/repos/projects/create_spec.rb
@@ -32,17 +32,17 @@
 
     it "should create resource" do
       subject.create owner, repo, inputs
-      a_post(request_path).with(body: inputs).should have_been_made
+      expect(a_post(request_path).with(body: inputs)).to have_been_made
     end
 
     it "should return the resource" do
       project = subject.create owner, repo, inputs
-      project.name.should == 'Projects Documentation'
+      expect(project.name).to eq 'Projects Documentation'
     end
 
     it "should return mash type" do
       project = subject.create owner, repo, inputs
-      project.should be_a Github::ResponseWrapper
+      expect(project).to be_a Github::ResponseWrapper
     end
   end
 end # create
diff --git a/spec/github/client/repos/projects/list_spec.rb b/spec/github/client/repos/projects/list_spec.rb
@@ -8,25 +8,25 @@
   let(:repo) { 'github' }
   let(:request_path) { "/repos/#{user}/#{repo}/projects" }
 
-  before {
+  before do
     stub_get(request_path)
-      .with(headers: {'Accept'=>'application/vnd.github.inertia-preview+json'})
+      .with(headers: { 'Accept' => 'application/vnd.github.inertia-preview+json' })
       .to_return(
         body: body,
         status: status,
         headers: {
           content_type: "application/json; charset=utf-8"
         }
       )
-  }
+  end
 
   after { reset_authentication_for(subject) }
 
   context "resource found" do
     let(:body)   { fixture('repos/projects.json') }
     let(:status) { 200 }
 
-    it { should respond_to :all }
+    it { expect(subject).to respond_to :all }
 
     it { expect { subject.list }.to raise_error(ArgumentError) }
 
@@ -36,7 +36,7 @@
 
     it "should get the resources" do
       subject.list user, repo
-      a_get(request_path).should have_been_made
+      expect(a_get(request_path)).to have_been_made
     end
 
     it_should_behave_like 'an array of resources' do
@@ -45,13 +45,13 @@
 
     it "should get project information" do
       projects = subject.list user, repo
-      projects.first.name.should == 'Projects Documentation'
+      expect(projects.first.name).to eq 'Projects Documentation'
     end
 
     it "should yield to a block" do
       yielded = []
       result = subject.list(user, repo) { |obj| yielded << obj }
-      yielded.should == result
+      expect(yielded).to eq result
     end
   end
 
diff --git a/spec/integration/repos_spec.rb b/spec/integration/repos_spec.rb
@@ -35,5 +35,4 @@
   its(:pubsubhubbub)  { should be_a Github::Client::Repos::PubSubHubbub }
 
   its(:projects)      { should be_a Github::Client::Repos::Projects }
-
 end # Github::Repos
diff --git a/spec/unit/client/orgs/projects/create_spec.rb b/spec/unit/client/orgs/projects/create_spec.rb
@@ -30,17 +30,17 @@
 
     it "should create resource" do
       subject.create org, inputs
-      a_post(request_path).with(body: inputs).should have_been_made
+      expect(a_post(request_path).with(body: inputs)).to have_been_made
     end
 
     it "should return the resource" do
       project = subject.create org, inputs
-      project.name.should == 'Projects Documentation'
+      expect(project.name).to eq 'Projects Documentation'
     end
 
     it "should return mash type" do
       project = subject.create org, inputs
-      project.should be_a Github::ResponseWrapper
+      expect(project).to be_a Github::ResponseWrapper
     end
   end
 end # create
diff --git a/spec/unit/client/projects/delete_spec.rb b/spec/unit/client/projects/delete_spec.rb
@@ -15,11 +15,11 @@
 
   after { reset_authentication_for subject }
 
-  it { should respond_to :remove }
+  it { expect(subject).to respond_to :remove }
 
   it "should delete the resource successfully" do
     subject.delete project_id
-    a_delete(request_path).should have_been_made
+    expect(a_delete(request_path)).to have_been_made
   end
 
   it "should fail to delete resource without 'id' parameter" do
