Skip to content

Commit 02c0972

Browse files
ejguanfacebook-github-bot
authored andcommitted
Always upload TorchData nightly release (meta-pytorch#503)
Summary: Based on the offline discussion with Vitaly, we want to upload TorchData nightly releases even if tests are failing. It's required by downstream library when PyTorch Core nightly updated but TorchData nightly still depends on the previous PT Core nightly. Pull Request resolved: meta-pytorch#503 Reviewed By: NivekT Differential Revision: D37049785 Pulled By: ejguan fbshipit-source-id: f65a166daa9646eb8251c418c3a416c51d3578e4
1 parent 843658c commit 02c0972

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/_build_test_upload.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ jobs:
159159
pip3 install -r test/requirements.txt
160160
pytest --no-header -v test --ignore=test/test_period.py --ignore=test/test_text_examples.py --ignore=test/test_audio_examples.py
161161
- name: Upload Wheels to Github
162+
if: always()
162163
uses: actions/upload-artifact@v2
163164
with:
164165
name: torchdata-artifact
@@ -269,7 +270,16 @@ jobs:
269270
conda activate conda_build_env
270271
conda install -yq conda-build -c conda-forge
271272
packaging/build_conda.sh
273+
- name: Install TorchData Conda Package
274+
shell: bash -l {0}
275+
run: conda install --offline conda-bld/*/torchdata-*.tar.bz2
276+
- name: Run DataPipes Tests with pytest
277+
shell: bash
278+
run: |
279+
pip3 install -r test/requirements.txt
280+
pytest --no-header -v test --ignore=test/test_period.py --ignore=test/test_text_examples.py --ignore=test/test_audio_examples.py
272281
- name: Upload Conda Package to Github
282+
if: always()
273283
uses: actions/upload-artifact@v2
274284
with:
275285
name: torchdata-artifact

packaging/torchdata/meta.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ test:
4747
# The following packages are not on the default conda channel
4848
# - iopath
4949
# - rarfile
50-
commands:
51-
- pytest --no-header -v test --ignore=test/test_period.py --ignore=test/test_text_examples.py --ignore=test/test_audio_examples.py
5250

5351
about:
5452
home: https://github.com/pytorch/data

0 commit comments

Comments
 (0)