Skip to content

Commit 0f93616

Browse files
ejguanfacebook-github-bot
authored andcommitted
Fix conda linux release and trigger uploading with partial wheel/conda build (meta-pytorch#323)
Summary: Changes: - For conda package, we need to enforce testing using cpuonly version of PyTorch, since we don't have cuda on CI machines. - Remove all `if` condition to make sure that wheel/conda uploading happens even when a few wheels/conda packages are not built successfully. See the failing workflow last night: https://github.com/pytorch/data/actions/runs/2034148892 Pull Request resolved: meta-pytorch#323 Reviewed By: NivekT Differential Revision: D35114599 Pulled By: ejguan fbshipit-source-id: 6e66dba8b368a9579b40a7d6aed87a55eaaeec5b
1 parent 6165258 commit 0f93616

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

.github/workflows/_build_test_upload.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ jobs:
5353
id: get_release_type
5454

5555
wheel_build_test:
56-
if: ${{ needs.get_release_type.outputs.type }}
5756
needs: get_release_type
5857
runs-on: ${{ matrix.os }}
5958
strategy:
@@ -107,7 +106,7 @@ jobs:
107106
path: dist/torchdata*.whl
108107

109108
wheel_upload:
110-
if: always() && ${{ needs.get_release_type.outputs.type }}
109+
if: always()
111110
needs: [get_release_type, wheel_build_test]
112111
runs-on: ubuntu-latest
113112
outputs:
@@ -160,7 +159,6 @@ jobs:
160159
dist/torchdata*.whl
161160
162161
conda_build_test:
163-
if: ${{ needs.get_release_type.outputs.type }}
164162
needs: get_release_type
165163
runs-on: ${{ matrix.os }}
166164
strategy:
@@ -201,7 +199,7 @@ jobs:
201199
path: conda-bld/*/torchdata-*.tar.bz2
202200

203201
conda_upload:
204-
if: always() && ${{ needs.get_release_type.outputs.type }}
202+
if: always()
205203
needs: [get_release_type, conda_build_test]
206204
runs-on: ubuntu-latest
207205
container: continuumio/miniconda3

packaging/torchdata/meta.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ test:
3131
source_files:
3232
- test
3333
requires:
34+
- cpuonly
3435
- pytest
3536
- expecttest
3637
- fsspec

0 commit comments

Comments
 (0)