Merge pull request #930 from bigplaice/dual-parser-v5

gaoxueyu · web-flow · commit 2b0bbcd6a83d · 2025-10-27T14:43:37.000+08:00
refine comments for dual parser
diff --git a/src/backend/oracle_parser/liboracle_parser.c b/src/backend/oracle_parser/liboracle_parser.c
@@ -397,18 +397,18 @@ ora_base_yylex(YYSTYPE *lvalp, YYLTYPE *llocp, ora_core_yyscan_t yyscanner)
 			while (token != 0 && token != ';')
 			{
 				/*
-				 * support anonymous block
+				 * support anonymous block.
 				 * In the PLSQL, the cursor declare must be 'CURSOR ...',
 				 * not '... CURSOR ...'.
 				 *
-				 * PLSQL support type xxx is ref cursor grammer
-				 * so we check the last token is ref
-				 * declare cursor don't support ref for the cursor name
+				 * PLSQL supports "type xxx is ref cursor" grammer
+				 * so we check the last token is ref or not.
+				 * declare cursor doesn't support ref for the cursor name.
 				 *
-				 * Inline function support cursor
-				 * we judge it is the cursor of SQL, if it next token
+				 * Inline function supports cursor
+				 * we know it is the cursor of SQL, if the next token
 				 * is WITH or FOR or WITHOUT. see details for ora_gram.y about
-				 * declare cursor stmt
+				 * declare cursor stmt.
 				 */
 				if (token == CURSOR)
 					has_cursor = true;
@@ -604,7 +604,7 @@ ora_base_yylex(YYSTYPE *lvalp, YYLTYPE *llocp, ora_core_yyscan_t yyscanner)
 					}
 
 					/*
-					 * there, maybe package body has init block
+					 * package body may have init block
 					 */
 					if (yyextra->body_style == OraBody_PACKAGEBODY &&
 						blocklevel == 0)
diff --git a/src/backend/oracle_parser/ora_scan.l b/src/backend/oracle_parser/ora_scan.l
@@ -486,7 +486,7 @@ other			.
 
 <xc>{
 {xcstart}		{
-					/* Simply don't consider nesting for compatibility with Oracle's comments */
+					/* don't consider nesting for compatibility of Oracle's comments */
 					//(yyextra->xcdepth)++;
 					/* Put back any characters past slash-star; see above */
 					yyless(2);
@@ -846,7 +846,7 @@ other			.
 						int		len = 0;
 
 						BEGIN(INITIAL);
-						/* get q' escaped character,really character */
+						/* get q' escaped character, the real character */
 
 						oldstr = litbufdup(yyscanner);
 						len = strlen(oldstr);
@@ -942,7 +942,7 @@ other			.
 						yyerror("zero-length delimited identifier");
 					ident = litbufdup(yyscanner);
 
-					/* Convert the upper case identifier to the lower case, and the lower
+					/* Convert the upper case identifier to the lower case one, and the lower
 					 * case to the upper case, if the identifier is quoted by the double
 					 * quotes.
 					 */
@@ -1473,7 +1473,7 @@ ora_scanner_init(const char *str,
 
 
 /*
- * Called after parsing is done to clean up after ora_scanner_init()
+ * when parsing is done, clean up after ora_scanner_init()
  */
 void
 ora_scanner_finish(ora_core_yyscan_t yyscanner)
