fix: use fixed date in autonomous transaction test for determinism

rophy · rophy · commit 72d01735ccb9 · 2025-12-03T15:51:00.000Z
diff --git a/src/pl/plisql/src/expected/plisql_autonomous.out b/src/pl/plisql/src/expected/plisql_autonomous.out
@@ -449,29 +449,29 @@ SELECT id, msg FROM autonomous_test WHERE id = 53;
 -- Test 19: Function returning DATE (pass-by-value)
 -- Tests date type handling
 --
-CREATE OR REPLACE FUNCTION test_function_date(p_days_offset INT) RETURN DATE AS
+CREATE OR REPLACE FUNCTION test_function_date(p_base_date DATE, p_days_offset INT) RETURN DATE AS
 DECLARE
     PRAGMA AUTONOMOUS_TRANSACTION;
     v_result DATE;
 BEGIN
-    v_result := CURRENT_DATE + p_days_offset;
+    v_result := p_base_date + p_days_offset;
     INSERT INTO autonomous_test VALUES (54, 'date: ' || v_result::TEXT, 'committed');
     RETURN v_result;
 END;
 /
 COMMIT;
 WARNING:  there is no transaction in progress
--- Returns date 7 days from now
-SELECT test_function_date(7) AS date_result;
+-- Returns date 7 days from base date (using fixed date for deterministic test)
+SELECT test_function_date('2025-01-01'::DATE, 7) AS date_result;
  date_result 
 -------------
- 2025-12-08
+ 2025-01-08
 (1 row)
 
 SELECT id, msg FROM autonomous_test WHERE id = 54;
  id |       msg        
 ----+------------------
- 54 | date: 2025-12-08
+ 54 | date: 2025-01-08
 (1 row)
 
 --
@@ -534,6 +534,6 @@ DROP FUNCTION test_function_text(TEXT);
 DROP FUNCTION inner_function(INT);
 DROP FUNCTION outer_function(INT);
 DROP FUNCTION test_function_numeric(NUMERIC);
-DROP FUNCTION test_function_date(INT);
+DROP FUNCTION test_function_date(DATE, INT);
 DROP FUNCTION test_function_boolean(INT);
 DROP TABLE autonomous_test;
diff --git a/src/pl/plisql/src/pl_exec.c b/src/pl/plisql/src/pl_exec.c
@@ -500,7 +500,7 @@ static void plisql_anonymous_return_out_parameter(PLiSQL_execstate * estate, PLi
  *
  * @param func The PLiSQL_function descriptor to execute.
  * @param fcinfo Call context and argument/return storage (FunctionCallInfo).
- *               May be NULL in some internal contexts.
+ *               Must be non-NULL for executable calls.
  * @param simple_eval_estate Optional EState to use for simple-expression
  *               evaluation; pass NULL to use the session-shared evaluator.
  * @param simple_eval_resowner Optional ResourceOwner associated with
diff --git a/src/pl/plisql/src/sql/plisql_autonomous.sql b/src/pl/plisql/src/sql/plisql_autonomous.sql
@@ -390,21 +390,21 @@ SELECT id, msg FROM autonomous_test WHERE id = 53;
 -- Test 19: Function returning DATE (pass-by-value)
 -- Tests date type handling
 --
-CREATE OR REPLACE FUNCTION test_function_date(p_days_offset INT) RETURN DATE AS
+CREATE OR REPLACE FUNCTION test_function_date(p_base_date DATE, p_days_offset INT) RETURN DATE AS
 DECLARE
     PRAGMA AUTONOMOUS_TRANSACTION;
     v_result DATE;
 BEGIN
-    v_result := CURRENT_DATE + p_days_offset;
+    v_result := p_base_date + p_days_offset;
     INSERT INTO autonomous_test VALUES (54, 'date: ' || v_result::TEXT, 'committed');
     RETURN v_result;
 END;
 /
 
 COMMIT;
 
--- Returns date 7 days from now
-SELECT test_function_date(7) AS date_result;
+-- Returns date 7 days from base date (using fixed date for deterministic test)
+SELECT test_function_date('2025-01-01'::DATE, 7) AS date_result;
 SELECT id, msg FROM autonomous_test WHERE id = 54;
 
 --
@@ -449,6 +449,6 @@ DROP FUNCTION test_function_text(TEXT);
 DROP FUNCTION inner_function(INT);
 DROP FUNCTION outer_function(INT);
 DROP FUNCTION test_function_numeric(NUMERIC);
-DROP FUNCTION test_function_date(INT);
+DROP FUNCTION test_function_date(DATE, INT);
 DROP FUNCTION test_function_boolean(INT);
 DROP TABLE autonomous_test;

Original file line number	Diff line number	Diff line change
`@@ -500,7 +500,7 @@ static void plisql_anonymous_return_out_parameter(PLiSQL_execstate * estate, PLi`
`500`	`500`	`*`
`501`	`501`	`* @param func The PLiSQL_function descriptor to execute.`
`502`	`502`	`* @param fcinfo Call context and argument/return storage (FunctionCallInfo).`
`503`		`- * May be NULL in some internal contexts.`
	`503`	`+ * Must be non-NULL for executable calls.`
`504`	`504`	`* @param simple_eval_estate Optional EState to use for simple-expression`
`505`	`505`	`* evaluation; pass NULL to use the session-shared evaluator.`
`506`	`506`	`* @param simple_eval_resowner Optional ResourceOwner associated with`