Skip to content

Commit ba9c6f3

Browse files
authored
Merge pull request #1196 from yasir-hussain-shah/fix/ivorysql_prefix_configs
reserve ivorysql prefix for gucs
2 parents 05da8ad + 9985869 commit ba9c6f3

3 files changed

Lines changed: 12 additions & 0 deletions

File tree

contrib/ivorysql_ora/expected/ora_misc_functions.out

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4181,3 +4181,10 @@ reset nls_date_format;
41814181
reset nls_timestamp_format;
41824182
reset nls_timestamp_tz_format;
41834183
reset default_text_search_config;
4184+
-- should throw errors, because dummy_config is not a valid configuration name
4185+
set ivorysql.dummy_config to dummy;
4186+
ERROR: invalid configuration parameter name "ivorysql.dummy_config"
4187+
DETAIL: "ivorysql" is a reserved prefix.
4188+
reset ivorysql.dummy_config;
4189+
ERROR: invalid configuration parameter name "ivorysql.dummy_config"
4190+
DETAIL: "ivorysql" is a reserved prefix.

contrib/ivorysql_ora/sql/ora_misc_functions.sql

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2345,3 +2345,6 @@ reset nls_date_format;
23452345
reset nls_timestamp_format;
23462346
reset nls_timestamp_tz_format;
23472347
reset default_text_search_config;
2348+
-- should throw errors, because dummy_config is not a valid configuration name
2349+
set ivorysql.dummy_config to dummy;
2350+
reset ivorysql.dummy_config;

contrib/ivorysql_ora/src/ivorysql_ora.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,8 @@ _PG_init(void)
126126
0,
127127
utl_file_umask_check_hook,
128128
utl_file_umask_assign_hook, NULL);
129+
130+
MarkGUCPrefixReserved("ivorysql");
129131
}
130132

131133
/*

0 commit comments

Comments
 (0)