Skip to content

Commit 56017c4

Browse files
committed
docs: swap default branch, document branches in CONTRIBUTING.md
1 parent 49d9493 commit 56017c4

File tree

4 files changed

+33
-53
lines changed

4 files changed

+33
-53
lines changed

CHANGELOG.md

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,10 @@
22

33
Please see each package's `CHANGELOG.md` for changes.
44

5-
* **`ionic`**:
6-
[`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/master/packages/ionic/CHANGELOG.md)
7-
* **`@ionic/cli-framework`**:
8-
[`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/master/packages/%40ionic/cli-framework/CHANGELOG.md)
9-
* **`@ionic/cli-utils`**:
10-
[`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/master/packages/%40ionic/cli-utils/CHANGELOG.md)
11-
* **`@ionic/discover`**:
12-
[`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/master/packages/%40ionic/discover/CHANGELOG.md)
13-
* **`@ionic/lab`**:
14-
[`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/master/packages/%40ionic/lab/CHANGELOG.md)
15-
* **`@ionic/schematics-angular`**:
16-
[`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/master/packages/%40ionic/schematics-angular/CHANGELOG.md)
17-
* **`@ionic/v1-toolkit`**:
18-
[`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/master/packages/%40ionic/v1-toolkit/CHANGELOG.md)
5+
* **`ionic`**: [`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/develop/packages/ionic/CHANGELOG.md)
6+
* **`@ionic/cli-framework`**: [`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/develop/packages/%40ionic/cli-framework/CHANGELOG.md)
7+
* **`@ionic/cli-utils`**: [`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/develop/packages/%40ionic/cli-utils/CHANGELOG.md)
8+
* **`@ionic/discover`**: [`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/develop/packages/%40ionic/discover/CHANGELOG.md)
9+
* **`@ionic/lab`**: [`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/develop/packages/%40ionic/lab/CHANGELOG.md)
10+
* **`@ionic/schematics-angular`**: [`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/develop/packages/%40ionic/schematics-angular/CHANGELOG.md)
11+
* **`@ionic/v1-toolkit`**: [`CHANGELOG.md`](https://github.com/ionic-team/ionic-cli/blob/develop/packages/%40ionic/v1-toolkit/CHANGELOG.md)

CONTRIBUTING.md

Lines changed: 21 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@
44
Page](https://ionicframework.com/support) for general support questions. The
55
issues on GitHub should be reserved for bug reports and feature requests.
66

7+
### Branches
8+
9+
* [`develop`](https://github.com/ionic-team/ionic-cli/tree/develop): **development** branch
10+
* [`master`](https://github.com/ionic-team/ionic-cli/tree/master): **stable** version (`npm install -g ionic`)
11+
* [`3.x`](https://github.com/ionic-team/ionic-cli/tree/3.x): **previous** version (`npm install -g ionic@3`)
12+
* [`2.x`](https://github.com/ionic-team/ionic-cli/tree/2.x): **legacy** version (`npm install -g ionic@legacy`)
13+
714
### Bug Reports
815

916
Run the command(s) with `--verbose` to produce debugging output. We may ask for
@@ -39,29 +46,20 @@ The Ionic CLI is organized into a monorepo. Here are the packages:
3946

4047
##### General Purpose
4148

42-
* [`packages/ionic`](https://github.com/ionic-team/ionic-cli/tree/master/packages/ionic):
43-
Ionic CLI executable.
44-
* [`packages/@ionic/cli-utils`](https://github.com/ionic-team/ionic-cli/tree/master/packages/%40ionic/cli-utils):
45-
Ionic CLI library and utilities.
46-
* [`packages/@ionic/cli-framework`](https://github.com/ionic-team/ionic-cli/tree/master/packages/%40ionic/cli-framework):
47-
Framework for command-line programs.
48-
* [`packages/@ionic/discover`](https://github.com/ionic-team/ionic-cli/tree/master/packages/%40ionic/discover):
49-
Service discovery library used for `ionic serve` with the [Ionic
50-
DevApp](https://ionicframework.com/docs/pro/devapp/).
51-
* [`packages/@ionic/lab`](https://github.com/ionic-team/ionic-cli/tree/master/packages/%40ionic/lab):
52-
Utility CLI for Ionic Lab, used by `ionic serve`.
49+
* [`packages/ionic`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/ionic): Ionic CLI executable.
50+
* [`packages/@ionic/cli-utils`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/%40ionic/cli-utils): Ionic CLI library and utilities.
51+
* [`packages/@ionic/cli-framework`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/%40ionic/cli-framework): Framework for command-line programs.
52+
* [`packages/@ionic/discover`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/%40ionic/discover): Service discovery library used for `ionic serve` with the [Ionic DevApp](https://ionicframework.com/docs/pro/devapp/).
53+
* [`packages/@ionic/lab`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/%40ionic/lab): Utility CLI for Ionic Lab, used by `ionic serve`.
5354

5455
##### Ionic/Angular 4+
5556

56-
* [`packages/@ionic/ng-toolkit`](https://github.com/ionic-team/ionic-cli/tree/master/packages/%40ionic/ng-toolkit):
57-
Builders for Ionic/Angular 4+.
58-
* [`packages/@ionic/schematics-angular`](https://github.com/ionic-team/ionic-cli/tree/master/packages/%40ionic/schematics-angular):
59-
Schematics for `ng generate`.
57+
* [`packages/@ionic/ng-toolkit`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/%40ionic/ng-toolkit): Builders for Ionic/Angular 4+.
58+
* [`packages/@ionic/schematics-angular`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/%40ionic/schematics-angular): Schematics for `ng generate`.
6059

6160
##### Ionic 1
6261

63-
* [`packages/@ionic/v1-toolkit`](https://github.com/ionic-team/ionic-cli/tree/master/packages/%40ionic/v1-toolkit):
64-
Utility CLI for Ionic v1 Apps, used by `ionic serve`.
62+
* [`packages/@ionic/v1-toolkit`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/%40ionic/v1-toolkit): Utility CLI for Ionic v1 Apps, used by `ionic serve`.
6563

6664
#### Toolset
6765

@@ -126,12 +124,11 @@ Guide](https://nodejs.org/en/docs/guides/debugging-getting-started/).
126124

127125
TODO: Be helpful about where to look for commands, utilities, etc.
128126

129-
##### Publishing Steps
127+
##### Publishing
130128

131-
1. Cancel any watch scripts.
132-
1. Write notable changes in the package(s)'s `CHANGELOG.md` file(s).
133-
1. For...
129+
Publishing occurs in CI when new changes are merged into `master`.
134130

135-
* ...testing releases: `npm run publish:testing`
136-
* ...canary releases: `npm run publish:canary`
137-
* ...stable releases: `npm run publish`
131+
To publish **testing** versions, follow these steps:
132+
133+
1. Cancel any watch scripts.
134+
1. Run `npm run publish:testing`

README.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,6 @@
66
The Ionic command line interface (CLI) is your go-to tool for developing
77
[Ionic][ionic-homepage] apps.
88

9-
We have several branches for CLI versions:
10-
11-
* [`master`](https://github.com/ionic-team/ionic-cli) (stable): `npm install -g
12-
ionic`
13-
* [`3.x`](https://github.com/ionic-team/ionic-cli/tree/3.x) (old): `npm install
14-
-g ionic@3`
15-
* [`2.x`](https://github.com/ionic-team/ionic-cli/tree/2.x) (legacy): `npm
16-
install -g ionic@legacy`
17-
189
:book: **Documentation**:
1910
[https://beta.ionicframework.com/docs/cli/overview][ionic-cli-docs]
2011

@@ -23,8 +14,7 @@ general support questions. The issues on GitHub should be reserved for bug
2314
reports and feature requests.
2415

2516
:sparkling_heart: **Want to contribute?** Please see
26-
[CONTRIBUTING.md](https://github.com/ionic-team/ionic-cli/blob/master/CONTRIBUTING.md).
27-
17+
[CONTRIBUTING.md](https://github.com/ionic-team/ionic-cli/blob/develop/CONTRIBUTING.md).
2818

2919
[ionic-homepage]: https://ionicframework.com
3020
[ionic-cli-docs]: https://beta.ionicframework.com/docs/cli/overview

packages/ionic/CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ Aside from a few edge cases listed below, upgrading to CLI 4 should be seamless.
2828
* Support for legacy Ionic Cloud ended on January 31st, 2018. The `ionic upload` and `ionic package` commands have been removed from the CLI. Support for [Ionic Pro](https://ionicframework.com/pro/) will be a major focus for the CLI going forward. :ok_hand:
2929
* The `app_id` property in `ionic.config.json` has been renamed to `pro_id` and is now optional (see [#3038](https://github.com/ionic-team/ionic-cli/issues/3038)). The CLI automatically detects this and changes it, but this notice is here if your build scripts rely on the setting.
3030
* `ionic build` will no longer run `cordova prepare`. Instead, run `ionic cordova prepare <platform>`, which performs an Ionic build beforehand.
31-
* Ionic Lab has been moved into the [`@ionic/lab`](https://github.com/ionic-team/ionic-cli/tree/master/packages/@ionic/lab) package, which will need to be installed for Lab to work.
31+
* Ionic Lab has been moved into the [`@ionic/lab`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/@ionic/lab) package, which will need to be installed for Lab to work.
3232
* The `conference` starter template has been removed from `ionic start`. To clone existing apps (as opposed to starting new apps from starter templates), please use the app's repository URL. For example, to create the conference app, use `ionic start "Conference App" https://github.com/ionic-team/ionic-conference-app`.
3333
* The `--display-name` option for `ionic start` has been removed. The `name` argument is now used as the display name and slugified for directory name, package name, etc. To provide a custom slug, use `--project-id` (see [#3038](https://github.com/ionic-team/ionic-cli/issues/3038)).
3434
* The `ionic:watch:before` npm script hook has been renamed to `ionic:serve:before`, but behaves the same.
3535
* `ionic doctor check` will now _only_ print issues and exit with exit code 1 if issues are found. Use `ionic doctor treat` to attempt automatic fixes.
3636
* `ionic doctor ignore` has been removed in favor of `ionic config set -g doctor.issues.<issue>.ignored true`).
37-
* Ionic 1 build/serve functionality has been moved into the [`@ionic/v1-toolkit`](https://github.com/ionic-team/ionic-cli/tree/master/packages/@ionic/v1-toolkit) package, which will need to be installed in your Ionic 1 project(s). The file watcher, [chokidar](https://github.com/paulmillr/chokidar), has been updated to 2.0.0, which will require those using `watchPatterns` to [always use POSIX-style slashes](https://github.com/paulmillr/chokidar/blob/master/CHANGELOG.md#chokidar-200-dec-29-2017) (not an issue if you've never used a backslash in globs for Windows).
38-
* The gulp integration has been removed from the CLI and put into the [`@ionic/v1-toolkit`](https://github.com/ionic-team/ionic-cli/tree/master/packages/@ionic/v1-toolkit) package, which is only for Ionic v1 apps.
37+
* Ionic 1 build/serve functionality has been moved into the [`@ionic/v1-toolkit`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/@ionic/v1-toolkit) package, which will need to be installed in your Ionic 1 project(s). The file watcher, [chokidar](https://github.com/paulmillr/chokidar), has been updated to 2.0.0, which will require those using `watchPatterns` to [always use POSIX-style slashes](https://github.com/paulmillr/chokidar/blob/master/CHANGELOG.md#chokidar-200-dec-29-2017) (not an issue if you've never used a backslash in globs for Windows).
38+
* The gulp integration has been removed from the CLI and put into the [`@ionic/v1-toolkit`](https://github.com/ionic-team/ionic-cli/tree/develop/packages/@ionic/v1-toolkit) package, which is only for Ionic v1 apps.
3939

4040
#### :rocket: Enhancements
4141

@@ -61,7 +61,7 @@ Aside from a few edge cases listed below, upgrading to CLI 4 should be seamless.
6161
#### :house: Internal
6262

6363
* A huge amount of code refactoring has been accomplished to prepare the CLI for a scalable, flexible future. Changes in behavior and help output based upon environment and config are now trivially accomplished.
64-
* The [CLI Framework](https://github.com/ionic-team/ionic-cli/tree/master/packages/%40ionic/cli-framework), a (currently) internal framework for building general-purpose command-line programs, has had many features added to support the utility CLIs such as `ionic-lab` and `ionic-v1`.
64+
* The [CLI Framework](https://github.com/ionic-team/ionic-cli/tree/develop/packages/%40ionic/cli-framework), a (currently) internal framework for building general-purpose command-line programs, has had many features added to support the utility CLIs such as `ionic-lab` and `ionic-v1`.
6565
* Ionic Lab has been rebuilt using [StencilJS](https://stenciljs.com) and now works for any Ionic Framework version.
6666

6767
## Older Changes

0 commit comments

Comments
 (0)