linting

justinmerrell · justinmerrell · commit 65b4e12e8a48 · 2023-04-10T20:32:10.000-04:00
diff --git a/runpod/serverless/utils/rp_upload.py b/runpod/serverless/utils/rp_upload.py
@@ -180,7 +180,7 @@ def bucket_upload(job_id, file_list, bucket_creds):
             )
 
         bucket_urls.append(
-            f"{bucket_creds['endpointUrl']}/{bucket_creds['bucketName']}/{job_id}/{file}")
+            f"{bucket_creds['endpointUrl']}/{bucket_creds['bucketName']}/{job_id}/{selected_file}")
 
     return bucket_urls
 
diff --git a/tests/test_serverless/test_util_upload.py b/tests/test_serverless/test_util_upload.py
@@ -17,7 +17,7 @@
 class TestUploadUtility(unittest.TestCase):
     ''' Tests for upload utility '''
 
-    @patch('my_module.get_boto_client')
+    @patch('runpod.serverless.utils.rp_upload.get_boto_client')
     def test_upload_file_to_bucket(self, mock_get_boto_client):
         '''
         Tests upload_file_to_bucket
@@ -55,7 +55,10 @@ def test_upload_file_to_bucket(self, mock_get_boto_client):
             }, ExpiresIn=604800
         )
 
-    @patch('my_module.get_boto_client')
+        # Check to see if the presigned url is a string
+        self.assertIsInstance(presigned_url, str)
+
+    @patch('runpod.serverless.utils.rp_upload.get_boto_client')
     def test_upload_in_memory_object(self, mock_get_boto_client):
         '''
         Tests upload_in_memory_object
@@ -94,3 +97,6 @@ def test_upload_in_memory_object(self, mock_get_boto_client):
                 'Key': file_name
             }, ExpiresIn=604800
         )
+
+        # Check to see if the presigned url is a string
+        self.assertIsInstance(presigned_url, str)

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ def bucket_upload(job_id, file_list, bucket_creds):`
`180`	`180`	`)`
`181`	`181`
`182`	`182`	`bucket_urls.append(`
`183`		`- f"{bucket_creds['endpointUrl']}/{bucket_creds['bucketName']}/{job_id}/{file}")`
	`183`	`+ f"{bucket_creds['endpointUrl']}/{bucket_creds['bucketName']}/{job_id}/{selected_file}")`
`184`	`184`
`185`	`185`	`return bucket_urls`
`186`	`186`