Saving bugs when changing settings.

TheJoeFin · TheJoeFin · commit 30353085c2e8 · 2021-03-08T21:01:22.000-06:00
fixed bug where Icon was not parsing correctly
diff --git a/Helpers/AppSettings.cs b/Helpers/AppSettings.cs
@@ -20,6 +20,7 @@ public bool ActivateOnLaunch
             { 
                 _activateOnLaunch = value;
                 appSettings[nameof(ActivateOnLaunch)].Value = _activateOnLaunch.ToString();
+                configFile.Save(ConfigurationSaveMode.Modified);
             }
         }
 
@@ -32,6 +33,7 @@ public bool AutomaticallyLaunchWithWindows
             { 
                 _automaticallyLaunchWithWindows = value;
                 appSettings[nameof(AutomaticallyLaunchWithWindows)].Value = _automaticallyLaunchWithWindows.ToString();
+                configFile.Save(ConfigurationSaveMode.Modified);
             }
         }
 
@@ -45,6 +47,7 @@ public bool ShowMessageOnLaunch
             { 
                 _showMessageOnLaunch = value;
                 appSettings[nameof(ShowMessageOnLaunch)].Value = _showMessageOnLaunch.ToString();
+                configFile.Save(ConfigurationSaveMode.Modified);
             }
         }
 
@@ -58,6 +61,7 @@ public int DefaultDuration
             { 
                 _defaultDuration = value; 
                 appSettings[nameof(DefaultDuration)].Value = _defaultDuration.ToString();
+                configFile.Save(ConfigurationSaveMode.Modified);
             }
         }
 
@@ -71,6 +75,7 @@ public TrayIcon Icon
             { 
                 _icon = value; 
                 appSettings[nameof(Icon)].Value = _icon.ToString();
+                configFile.Save(ConfigurationSaveMode.Modified);
             }
         }
 
@@ -84,6 +89,7 @@ public List<int> Durations
             { 
                 _durations = value;
                 appSettings[nameof(Durations)].Value = string.Join(',',Durations.ToArray());
+                configFile.Save(ConfigurationSaveMode.Modified);
             }
         }
 
@@ -149,7 +155,7 @@ public AppSettings()
                     case "Mug":
                         _icon = TrayIcon.Mug;
                         break;
-                    case "Eye-ZZZ":
+                    case "EyeWithZzz":
                         _icon = TrayIcon.EyeWithZzz;
                         break;
                     default:
@@ -181,6 +187,8 @@ public AppSettings()
                 AddUpdateAppSettings(nameof(Durations), string.Join(',', _durations.ToArray()));
                 Console.WriteLine($"Error reading Durations app settings");
             }
+
+            configFile.Save(ConfigurationSaveMode.Modified);
         }
 
         void AddUpdateAppSettings(string key, string value)
diff --git a/SettingsForm.cs b/SettingsForm.cs
@@ -114,7 +114,6 @@ private async void setStartupCheckBox() {
         }
 
         private void okBtn_Click(object sender, EventArgs e) {
-            //Settings.Default.Save();
             this.Close();
         }
 

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ public bool ActivateOnLaunch`
`20`	`20`	`{`
`21`	`21`	`_activateOnLaunch = value;`
`22`	`22`	`appSettings[nameof(ActivateOnLaunch)].Value = _activateOnLaunch.ToString();`
	`23`	`+ configFile.Save(ConfigurationSaveMode.Modified);`
`23`	`24`	`}`
`24`	`25`	`}`
`25`	`26`
`@@ -32,6 +33,7 @@ public bool AutomaticallyLaunchWithWindows`
`32`	`33`	`{`
`33`	`34`	`_automaticallyLaunchWithWindows = value;`
`34`	`35`	`appSettings[nameof(AutomaticallyLaunchWithWindows)].Value = _automaticallyLaunchWithWindows.ToString();`
	`36`	`+ configFile.Save(ConfigurationSaveMode.Modified);`
`35`	`37`	`}`
`36`	`38`	`}`
`37`	`39`
`@@ -45,6 +47,7 @@ public bool ShowMessageOnLaunch`
`45`	`47`	`{`
`46`	`48`	`_showMessageOnLaunch = value;`
`47`	`49`	`appSettings[nameof(ShowMessageOnLaunch)].Value = _showMessageOnLaunch.ToString();`
	`50`	`+ configFile.Save(ConfigurationSaveMode.Modified);`
`48`	`51`	`}`
`49`	`52`	`}`
`50`	`53`
`@@ -58,6 +61,7 @@ public int DefaultDuration`
`58`	`61`	`{`
`59`	`62`	`_defaultDuration = value;`
`60`	`63`	`appSettings[nameof(DefaultDuration)].Value = _defaultDuration.ToString();`
	`64`	`+ configFile.Save(ConfigurationSaveMode.Modified);`
`61`	`65`	`}`
`62`	`66`	`}`
`63`	`67`
`@@ -71,6 +75,7 @@ public TrayIcon Icon`
`71`	`75`	`{`
`72`	`76`	`_icon = value;`
`73`	`77`	`appSettings[nameof(Icon)].Value = _icon.ToString();`
	`78`	`+ configFile.Save(ConfigurationSaveMode.Modified);`
`74`	`79`	`}`
`75`	`80`	`}`
`76`	`81`
`@@ -84,6 +89,7 @@ public List<int> Durations`
`84`	`89`	`{`
`85`	`90`	`_durations = value;`
`86`	`91`	`appSettings[nameof(Durations)].Value = string.Join(',',Durations.ToArray());`
	`92`	`+ configFile.Save(ConfigurationSaveMode.Modified);`
`87`	`93`	`}`
`88`	`94`	`}`
`89`	`95`
`@@ -149,7 +155,7 @@ public AppSettings()`
`149`	`155`	`case "Mug":`
`150`	`156`	`_icon = TrayIcon.Mug;`
`151`	`157`	`break;`
`152`		`- case "Eye-ZZZ":`
	`158`	`+ case "EyeWithZzz":`
`153`	`159`	`_icon = TrayIcon.EyeWithZzz;`
`154`	`160`	`break;`
`155`	`161`	`default:`
`@@ -181,6 +187,8 @@ public AppSettings()`
`181`	`187`	`AddUpdateAppSettings(nameof(Durations), string.Join(',', _durations.ToArray()));`
`182`	`188`	`Console.WriteLine($"Error reading Durations app settings");`
`183`	`189`	`}`
	`190`	`+`
	`191`	`+ configFile.Save(ConfigurationSaveMode.Modified);`
`184`	`192`	`}`
`185`	`193`
`186`	`194`	`void AddUpdateAppSettings(string key, string value)`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,6 @@ private async void setStartupCheckBox() {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`private void okBtn_Click(object sender, EventArgs e) {`
`117`		`- //Settings.Default.Save();`
`118`	`117`	`this.Close();`
`119`	`118`	`}`
`120`	`119`