Improve settings to check for null first

TheJoeFin · TheJoeFin · commit be3f48a2801a · 2021-03-17T05:59:50.000-05:00
diff --git a/Helpers/AppSettings.cs b/Helpers/AppSettings.cs
@@ -80,7 +80,8 @@ public AppSettings() {
             appSettings = configFile.AppSettings.Settings;
 
             try {
-                string ActivateOnLaunchresult = appSettings[nameof(ActivateOnLaunch)].Value;
+                KeyValueConfigurationElement ActivateOnLaunchSetting = appSettings[nameof(ActivateOnLaunch)];
+                string ActivateOnLaunchresult = ActivateOnLaunchSetting == null ? "false" : ActivateOnLaunchSetting.Value;
                 _activateOnLaunch = bool.Parse(ActivateOnLaunchresult);
             }
             catch (Exception) {
@@ -90,7 +91,8 @@ public AppSettings() {
             }
 
             try {
-                string AutomaticallyLaunchWithWindowsresult = appSettings[nameof(AutomaticallyLaunchWithWindows)].Value;
+                KeyValueConfigurationElement AutomaticallyLaunchWithWindowsSetting = appSettings[nameof(AutomaticallyLaunchWithWindows)];
+                string AutomaticallyLaunchWithWindowsresult = AutomaticallyLaunchWithWindowsSetting == null ? "false" : AutomaticallyLaunchWithWindowsSetting.Value;
                 _automaticallyLaunchWithWindows = bool.Parse(AutomaticallyLaunchWithWindowsresult);
             }
             catch (Exception) {
@@ -100,7 +102,8 @@ public AppSettings() {
             }
 
             try {
-                string ShowMessageOnLaunchresult = appSettings[nameof(ShowMessageOnLaunch)].Value;
+                KeyValueConfigurationElement ShowMessageOnLaunchSetting = appSettings[nameof(ShowMessageOnLaunch)];
+                string ShowMessageOnLaunchresult = ShowMessageOnLaunchSetting == null ? "true" : ShowMessageOnLaunchSetting.Value;
                 _showMessageOnLaunch = bool.Parse(ShowMessageOnLaunchresult);
             }
             catch (Exception) {
@@ -110,7 +113,8 @@ public AppSettings() {
             }
 
             try {
-                string DefaultDurationresult = appSettings[nameof(DefaultDuration)].Value;
+                KeyValueConfigurationElement DefaultDurationSetting = appSettings[nameof(DefaultDuration)];
+                string DefaultDurationresult = DefaultDurationSetting == null ? "0" : DefaultDurationSetting.Value;
                 _defaultDuration = int.Parse(DefaultDurationresult);
             }
             catch (Exception) {
@@ -120,7 +124,8 @@ public AppSettings() {
             }
 
             try {
-                string Iconresult = appSettings[nameof(Icon)].Value;
+                KeyValueConfigurationElement IconSetting = appSettings[nameof(Icon)];
+                string Iconresult = IconSetting == null ? "default" : IconSetting.Value;
                 switch (Iconresult) {
                     case "Mug":
                         _icon = TrayIcon.Mug;
@@ -140,7 +145,8 @@ public AppSettings() {
             }
 
             try {
-                string Durationsresult = appSettings[nameof(Durations)].Value;
+                KeyValueConfigurationElement DurationsSetting = appSettings[nameof(Durations)];
+                string Durationsresult = DurationsSetting == null ? "0,15,60,120,480" : DurationsSetting.Value;
                 List<string> splitResult = Durationsresult.Split(',').ToList();
 
                 _durations = new ObservableCollection<int>();

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,8 @@ public AppSettings() {`
`80`	`80`	`appSettings = configFile.AppSettings.Settings;`
`81`	`81`
`82`	`82`	`try {`
`83`		`- string ActivateOnLaunchresult = appSettings[nameof(ActivateOnLaunch)].Value;`
	`83`	`+ KeyValueConfigurationElement ActivateOnLaunchSetting = appSettings[nameof(ActivateOnLaunch)];`
	`84`	`+ string ActivateOnLaunchresult = ActivateOnLaunchSetting == null ? "false" : ActivateOnLaunchSetting.Value;`
`84`	`85`	`_activateOnLaunch = bool.Parse(ActivateOnLaunchresult);`
`85`	`86`	`}`
`86`	`87`	`catch (Exception) {`
`@@ -90,7 +91,8 @@ public AppSettings() {`
`90`	`91`	`}`
`91`	`92`
`92`	`93`	`try {`
`93`		`- string AutomaticallyLaunchWithWindowsresult = appSettings[nameof(AutomaticallyLaunchWithWindows)].Value;`
	`94`	`+ KeyValueConfigurationElement AutomaticallyLaunchWithWindowsSetting = appSettings[nameof(AutomaticallyLaunchWithWindows)];`
	`95`	`+ string AutomaticallyLaunchWithWindowsresult = AutomaticallyLaunchWithWindowsSetting == null ? "false" : AutomaticallyLaunchWithWindowsSetting.Value;`
`94`	`96`	`_automaticallyLaunchWithWindows = bool.Parse(AutomaticallyLaunchWithWindowsresult);`
`95`	`97`	`}`
`96`	`98`	`catch (Exception) {`
`@@ -100,7 +102,8 @@ public AppSettings() {`
`100`	`102`	`}`
`101`	`103`
`102`	`104`	`try {`
`103`		`- string ShowMessageOnLaunchresult = appSettings[nameof(ShowMessageOnLaunch)].Value;`
	`105`	`+ KeyValueConfigurationElement ShowMessageOnLaunchSetting = appSettings[nameof(ShowMessageOnLaunch)];`
	`106`	`+ string ShowMessageOnLaunchresult = ShowMessageOnLaunchSetting == null ? "true" : ShowMessageOnLaunchSetting.Value;`
`104`	`107`	`_showMessageOnLaunch = bool.Parse(ShowMessageOnLaunchresult);`
`105`	`108`	`}`
`106`	`109`	`catch (Exception) {`
`@@ -110,7 +113,8 @@ public AppSettings() {`
`110`	`113`	`}`
`111`	`114`
`112`	`115`	`try {`
`113`		`- string DefaultDurationresult = appSettings[nameof(DefaultDuration)].Value;`
	`116`	`+ KeyValueConfigurationElement DefaultDurationSetting = appSettings[nameof(DefaultDuration)];`
	`117`	`+ string DefaultDurationresult = DefaultDurationSetting == null ? "0" : DefaultDurationSetting.Value;`
`114`	`118`	`_defaultDuration = int.Parse(DefaultDurationresult);`
`115`	`119`	`}`
`116`	`120`	`catch (Exception) {`
`@@ -120,7 +124,8 @@ public AppSettings() {`
`120`	`124`	`}`
`121`	`125`
`122`	`126`	`try {`
`123`		`- string Iconresult = appSettings[nameof(Icon)].Value;`
	`127`	`+ KeyValueConfigurationElement IconSetting = appSettings[nameof(Icon)];`
	`128`	`+ string Iconresult = IconSetting == null ? "default" : IconSetting.Value;`
`124`	`129`	`switch (Iconresult) {`
`125`	`130`	`case "Mug":`
`126`	`131`	`_icon = TrayIcon.Mug;`
`@@ -140,7 +145,8 @@ public AppSettings() {`
`140`	`145`	`}`
`141`	`146`
`142`	`147`	`try {`
`143`		`- string Durationsresult = appSettings[nameof(Durations)].Value;`
	`148`	`+ KeyValueConfigurationElement DurationsSetting = appSettings[nameof(Durations)];`
	`149`	`+ string Durationsresult = DurationsSetting == null ? "0,15,60,120,480" : DurationsSetting.Value;`
`144`	`150`	`List<string> splitResult = Durationsresult.Split(',').ToList();`
`145`	`151`
`146`	`152`	`_durations = new ObservableCollection<int>();`