code changes based on feedback

aaronwalker · aaronwalker · commit cd42f1bae6dc · 2012-03-26T09:49:30.000+11:00
diff --git a/src/main/java/com/cloudbees/jenkins/Cleaner.java b/src/main/java/com/cloudbees/jenkins/Cleaner.java
@@ -65,7 +65,7 @@ protected void doRun() throws Exception {
         for (GitHubRepositoryName r : names) {
             for (GHRepository repo : r.resolve()) {
                 try {
-                    removeHook(repo,Trigger.all().get(DescriptorImpl.class).getHookUrl());
+                    removeHook(repo, Trigger.all().get(DescriptorImpl.class).getHookUrl());
                     LOGGER.fine("Removed a hook from "+r+"");
                     continue OUTER;
                 } catch (Throwable e) {
@@ -79,14 +79,14 @@ protected void doRun() throws Exception {
     //something like public void removeHook(String name, Map<String,String> config)
     private void removeHook(GHRepository repo, URL url) {
         try {
-            String _url = ((URL)url).toExternalForm();
+            String urlExternalForm = url.toExternalForm();
             for (GHHook h : repo.getHooks()) {
-                if (h.getName().equals("jenkins") && h.getConfig().get("jenkins_hook_url").equals(_url)) {
+                if (h.getName().equals("jenkins") && h.getConfig().get("jenkins_hook_url").equals(urlExternalForm)) {
                     h.delete();
                 }
             }
         } catch (IOException e) {
-            throw new GHException("Failed to update post-commit hooks",e);
+            throw new GHException("Failed to update post-commit hooks", e);
         }
     }
 
diff --git a/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java b/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java
@@ -159,10 +159,10 @@ public void run() {
 
     private boolean createJenkinsHook(GHRepository repo, URL url) {
         try {
-            repo.createHook("jenkins",Collections.singletonMap("jenkins_hook_url",url.toExternalForm()),null,true);
+            repo.createHook("jenkins", Collections.singletonMap("jenkins_hook_url", url.toExternalForm()), null, true);
             return true;
         } catch (IOException e) {
-            throw new GHException("Failed to update jenkins hooks",e);
+            throw new GHException("Failed to update jenkins hooks", e);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -159,10 +159,10 @@ public void run() {`
`159`	`159`
`160`	`160`	`private boolean createJenkinsHook(GHRepository repo, URL url) {`
`161`	`161`	`try {`
`162`		`- repo.createHook("jenkins",Collections.singletonMap("jenkins_hook_url",url.toExternalForm()),null,true);`
	`162`	`+ repo.createHook("jenkins", Collections.singletonMap("jenkins_hook_url", url.toExternalForm()), null, true);`
`163`	`163`	`return true;`
`164`	`164`	`} catch (IOException e) {`
`165`		`- throw new GHException("Failed to update jenkins hooks",e);`
	`165`	`+ throw new GHException("Failed to update jenkins hooks", e);`
`166`	`166`	`}`
`167`	`167`	`}`
`168`	`168`