Pass title prop

winterbe · winterbe · commit a0b0cded4a2c · 2015-02-05T07:59:02.000+01:00
diff --git a/src/main/java/com/winterbe/react/React.java b/src/main/java/com/winterbe/react/React.java
@@ -1,6 +1,7 @@
 package com.winterbe.react;
 
-import javax.script.ScriptEngine;
+import jdk.nashorn.api.scripting.NashornScriptEngine;
+
 import javax.script.ScriptEngineManager;
 import javax.script.ScriptException;
 import java.io.InputStream;
@@ -9,11 +10,11 @@
 
 public class React {
 
-    private ScriptEngine nashorn;
+    private NashornScriptEngine nashorn;
 
     public React() {
         try {
-            nashorn = new ScriptEngineManager().getEngineByName("nashorn");
+            nashorn = (NashornScriptEngine) new ScriptEngineManager().getEngineByName("nashorn");
             nashorn.eval("var window = this;");     // workaround for non-existing window
             nashorn.eval("load('https://cdnjs.cloudflare.com/ajax/libs/react/0.12.2/react.js')");
             nashorn.eval("load('http://cdnjs.cloudflare.com/ajax/libs/showdown/0.3.1/showdown.min.js')");
@@ -26,10 +27,12 @@ public React() {
     public String renderCommentBox() {
         try {
             nashorn.eval(readFromClassPath("static/example.js"));
-            Object html = nashorn.eval(readFromClassPath("static/renderToString.js"));
+            nashorn.eval(readFromClassPath("static/renderToString.js"));
+            String title = "Comments (rendered by server)";
+            Object html = nashorn.invokeFunction("renderCommentBox", title);
             return String.valueOf(html);
         }
-        catch (ScriptException e) {
+        catch (Exception e) {
             throw new IllegalStateException("failed to render react component", e);
         }
     }
diff --git a/src/main/resources/jsx/example.js b/src/main/resources/jsx/example.js
@@ -92,7 +92,7 @@ var CommentBox = React.createClass({
     render: function () {
         return (
             <div className="commentBox">
-                <h1>Comments</h1>
+                <h1>{this.props.title}</h1>
                 <CommentList data={this.state.data} />
                 <CommentForm onCommentSubmit={this.handleCommentSubmit} />
             </div>
diff --git a/src/main/resources/jsx/renderToDom.js b/src/main/resources/jsx/renderToDom.js
@@ -1,4 +1,4 @@
 React.render(
-    <CommentBox url='comments.json' pollInterval={5000} />,
+    <CommentBox title='Comments (rendered by client)' url='comments.json' pollInterval={5000} />,
     document.getElementById("content")
 );
diff --git a/src/main/resources/jsx/renderToString.js b/src/main/resources/jsx/renderToString.js
@@ -1,3 +1,5 @@
-React.renderToString(
-    <CommentBox url='comments.json' pollInterval={5000} />
-);
+var renderCommentBox = function (title) {
+    return React.renderToString(
+        <CommentBox title={title} url='comments.json' pollInterval={5000} />
+    );
+};
diff --git a/src/main/resources/static/example.js b/src/main/resources/static/example.js
@@ -92,7 +92,7 @@ var CommentBox = React.createClass({displayName: "CommentBox",
     render: function () {
         return (
             React.createElement("div", {className: "commentBox"}, 
-                React.createElement("h1", null, "Comments"), 
+                React.createElement("h1", null, this.props.title), 
                 React.createElement(CommentList, {data: this.state.data}), 
                 React.createElement(CommentForm, {onCommentSubmit: this.handleCommentSubmit})
             )
diff --git a/src/main/resources/static/renderToDom.js b/src/main/resources/static/renderToDom.js
@@ -1,4 +1,4 @@
 React.render(
-    React.createElement(CommentBox, {url: "comments.json", pollInterval: 5000}),
+    React.createElement(CommentBox, {title: "Comments (rendered by client)", url: "comments.json", pollInterval: 5000}),
     document.getElementById("content")
 );
diff --git a/src/main/resources/static/renderToString.js b/src/main/resources/static/renderToString.js
@@ -1,3 +1,5 @@
-React.renderToString(
-    React.createElement(CommentBox, {url: "comments.json", pollInterval: 5000})
-);
+var renderCommentBox = function (title) {
+    return React.renderToString(
+        React.createElement(CommentBox, {title: title, url: "comments.json", pollInterval: 5000})
+    );
+};

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ var CommentBox = React.createClass({displayName: "CommentBox",`
`92`	`92`	`render: function () {`
`93`	`93`	`return (`
`94`	`94`	`React.createElement("div", {className: "commentBox"},`
`95`		`- React.createElement("h1", null, "Comments"),`
	`95`	`+ React.createElement("h1", null, this.props.title),`
`96`	`96`	`React.createElement(CommentList, {data: this.state.data}),`
`97`	`97`	`React.createElement(CommentForm, {onCommentSubmit: this.handleCommentSubmit})`
`98`	`98`	`)`