Skip to content

Commit ecf43ff

Browse files
committed
Related to requirejs#325, organize dataMain tests in a folder, create a test for 325.
1 parent 0eec1ba commit ecf43ff

8 files changed

Lines changed: 50 additions & 11 deletions

File tree

tests/all.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ doh.registerUrl("baseUrl", "../baseUrl.html");
1111

1212
doh.registerUrl("config", "../config.html");
1313
doh.registerUrl("configRequirejs", "../configRequirejs.html");
14-
doh.registerUrl("dataMain", "../dataMain.html");
15-
doh.registerUrl("dataMainIndex", "../dataMainIndex/dataMainIndex.html");
14+
doh.registerUrl("dataMain", "../dataMain/dataMain.html");
15+
doh.registerUrl("dataMainIndex", "../dataMain/dataMainIndex/dataMainIndex.html");
16+
doh.registerUrl("dataMainBaseUrl", "../dataMain/baseUrl/dataMainBaseUrl.html");
1617

1718
if (hasToString) {
1819
doh.registerUrl("anonSimple", "../anon/anonSimple.html");
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
<!DOCTYPE html>
2+
<html>
3+
<head>
4+
<title>require.js: data-main baseUrl Test</title>
5+
<script type="text/javascript" src="../../doh/runner.js"></script>
6+
<script type="text/javascript" src="../../doh/_browserRunner.js"></script>
7+
<script>
8+
var require = {
9+
baseUrl: "./"
10+
};
11+
</script>
12+
<script type="text/javascript" data-main="src/main" src="../../../require.js"></script>
13+
</head>
14+
<body>
15+
<h1>require.js: data-main baseUrl Test</h1>
16+
17+
<p>Confirm that setting a baseUrl does not mess up the data-main module
18+
ID. More info:
19+
<a href="https://github.com/jrburke/requirejs/issues/325">325</a>.
20+
21+
<p>Check console for messages</p>
22+
</body>
23+
</html>

tests/dataMain/baseUrl/src/a.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
define({
2+
name: 'a'
3+
});
4+

tests/dataMain/baseUrl/src/main.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
define(['a'], function (a) {
2+
doh.register(
3+
"dataMainBaseUrl",
4+
[
5+
function dataMainBaseUrl(t){
6+
t.is("a", a.name);
7+
}
8+
]
9+
);
10+
doh.run();
11+
});
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
<html>
33
<head>
44
<title>require.js: data-main Test</title>
5-
<script type="text/javascript" src="doh/runner.js"></script>
6-
<script type="text/javascript" src="doh/_browserRunner.js"></script>
7-
<script type="text/javascript" data-main="dataMain.js" src="../require.js"></script>
5+
<script type="text/javascript" src="../doh/runner.js"></script>
6+
<script type="text/javascript" src="../doh/_browserRunner.js"></script>
7+
<script type="text/javascript" data-main="dataMain.js" src="../../require.js"></script>
88
</head>
99
<body>
1010
<h1>require.js: data-main Test</h1>
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
require({
2-
baseUrl: "./"
2+
baseUrl: "../"
33
},
44
["require", "simple"],
55
function(require, simple) {
66
doh.register(
7-
"dataMain",
7+
"dataMain",
88
[
99
function dataMain(t){
1010
t.is("blue", simple.color);

tests/dataMainIndex/dataMainIndex.html renamed to tests/dataMain/dataMainIndex/dataMainIndex.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,21 @@
22
<html>
33
<head>
44
<title>require.js: data-main index Test</title>
5-
<script type="text/javascript" src="../doh/runner.js"></script>
6-
<script type="text/javascript" src="../doh/_browserRunner.js"></script>
5+
<script type="text/javascript" src="../../doh/runner.js"></script>
6+
<script type="text/javascript" src="../../doh/_browserRunner.js"></script>
77
<script>
88
var require = {
99
baseUrl: "./"
1010
};
1111
</script>
12-
<script type="text/javascript" data-main="index.js" src="../../require.js"></script>
12+
<script type="text/javascript" data-main="index.js" src="../../../require.js"></script>
1313
</head>
1414
<body>
1515
<h1>require.js: data-main index Test</h1>
1616

1717
<p>Confirm that a data-main="index.js" with an inline config with a baseUrl
1818
works with a built script that has "index" as the top level define call. More info:
19-
<a href="https://github.com/jrburke/requirejs/issues/303"></a>.
19+
<a href="https://github.com/jrburke/requirejs/issues/303">303</a>.
2020

2121
<p>Check console for messages</p>
2222
</body>

0 commit comments

Comments
 (0)