Bug report
Disable all outputs while playing, the status shows error: Failed to open audio output.
Then, enable an output and send the play command: playback resumes, but the status still has that error.
Expected Behavior
Error cleared when playback resumed after output was enabled.
Actual Behavior
Error not cleared.
Version
Music Player Daemon 0.25 (v0.24.9-208-gcb72bc5bd+)
The error should probably be cleared in playlist::PlayAny before the return from the if (playing) branch. (changed in f43d7de)
diff --git a/src/queue/PlaylistControl.cxx b/src/queue/PlaylistControl.cxx
index 17ca93b44..1172c2e36 100644
--- a/src/queue/PlaylistControl.cxx
+++ b/src/queue/PlaylistControl.cxx
@@ -86,6 +86,8 @@ playlist::PlayAny(PlayerControl &pc)
if (queue.IsEmpty())
return;
+ pc.LockClearError();
+
if (playing) {
/* already playing: unpause playback, just in
case it was paused, and return */
@@ -93,7 +95,6 @@ playlist::PlayAny(PlayerControl &pc)
return;
}
- pc.LockClearError();
stop_on_error = false;
error_count = 0;
Bug report
Disable all outputs while playing, the status shows
error: Failed to open audio output.Then, enable an output and send the play command: playback resumes, but the status still has that error.
Expected Behavior
Error cleared when playback resumed after output was enabled.
Actual Behavior
Error not cleared.
Version
Music Player Daemon 0.25 (v0.24.9-208-gcb72bc5bd+)
The error should probably be cleared in
playlist::PlayAnybefore the return from theif (playing)branch. (changed in f43d7de)