Skip to content

Commit ec713de

Browse files
NRL-2060 Realign handler logs
1 parent 1c5c062 commit ec713de

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

layer/nrlf/core/decorators.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,11 @@ def _use_v2_permissions_model(headers: Dict[str, str]) -> bool:
156156

157157
def _load_v2_connection_metadata(headers: Dict[str, str], path: str):
158158
logger.log(LogReference.HANDLER004d)
159+
159160
metadata = parse_headers(headers, use_v2_permissions=True)
161+
logger.log(LogReference.HANDLER003, metadata=metadata.model_dump())
160162

161-
logger.log(LogReference.HANDLER004e)
163+
logger.log(LogReference.HANDLER004b)
162164
pointer_permissions = get_pointer_permissions_v2(metadata, path)
163165

164166
metadata.nrl_permissions_policy = PermissionsPolicy.model_validate(
@@ -169,10 +171,11 @@ def _load_v2_connection_metadata(headers: Dict[str, str], path: str):
169171
AccessControls.ALLOW_ALL_TYPES.value
170172
in metadata.nrl_permissions_policy.access_controls
171173
):
174+
logger.log(LogReference.HANDLER004a)
172175
metadata.nrl_permissions_policy.types = PointerTypes.list()
173176

174177
logger.log(
175-
LogReference.HANDLER004f,
178+
LogReference.HANDLER004c,
176179
permissions_policy=(
177180
metadata.nrl_permissions_policy.model_dump()
178181
if metadata.nrl_permissions_policy
@@ -184,13 +187,16 @@ def _load_v2_connection_metadata(headers: Dict[str, str], path: str):
184187

185188

186189
def load_connection_metadata(headers: Dict[str, str], config: Config, path=""):
190+
logger.log(LogReference.HANDLER002, headers=headers)
187191

188192
if _use_v2_permissions_model(headers):
189193
return _load_v2_connection_metadata(headers, path)
190194

191195
metadata = parse_headers(headers, use_v2_permissions=False)
196+
logger.log(LogReference.HANDLER003, metadata=metadata.model_dump())
197+
192198
if PERMISSION_ALLOW_ALL_POINTER_TYPES in metadata.nrl_permissions:
193-
logger.log(LogReference.HANDLER004b)
199+
logger.log(LogReference.HANDLER004a)
194200
metadata.pointer_types = PointerTypes.list()
195201
return metadata
196202

layer/nrlf/core/log_references.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,9 @@ class LogReference(Enum):
3030
)
3131
HANDLER004 = _Reference("INFO", "Authorisation lookup enabled")
3232
HANDLER004a = _Reference("INFO", "Authorisation lookup skipped for sync request")
33-
HANDLER004b = _Reference("INFO", "Parsing embedded permissions file from S3")
34-
HANDLER004c = _Reference("INFO", "Parsed embedded permissions file from S3")
33+
HANDLER004b = _Reference("INFO", "Parsing embedded permissions file")
34+
HANDLER004c = _Reference("INFO", "Parsed embedded permissions file")
3535
HANDLER004d = _Reference("INFO", "Using v2 permissions model")
36-
HANDLER004e = _Reference("INFO", "Parsing v2 permissions file from lambda layer")
37-
HANDLER004f = _Reference("INFO", "Parsed v2 permissions file from lambda layer")
3836
HANDLER005 = _Reference("WARN", "Rejecting request due to missing pointer types")
3937
HANDLER006 = _Reference("DEBUG", "Attempting to parse request parameters")
4038
HANDLER007 = _Reference("INFO", "Parsed request parameters")

0 commit comments

Comments
 (0)