I would suggest we go with the Google Style Guide for the following reasons:

Provides source control friendly IDE files. IntelliJ is the one we are using for this project and it is supported. This almost sealed the decision for me.
Seems to be comprehensive and relatively brief and easy to navigate.
I've read through it and it feels reasonable.

There are a couple of guidelines that are not inline with what I'm used to / personal taste. I generally try to use standards as is (i.e. resist personal preferences), and I'm happy to do the same here, but just sharing these:

2 space indentation - I can see the motivation, but never worked on projects with 2 space indentations before. Though, it may be necessary to get max line length to work.
80 or 100 max len - I would take the 100 or possibly even a bit more.

So, I would use the standard as is.

Project Guidelines (overrides to standard):

For existing APIs, don't break public interface in favor of coding style.
For new APIs, we can consider new styles, but consistency may have an impact on the decision.
We may choose a major version to make the breaking API changes in favor of cleaning up public interface.
If there are one-off violations in the public API, we could consider deprecating non-compliant API in favor of a new one. But that only works if these are one-offs.

Let me know your thoughts.

Scope of this specific work item:

Choose the coding standard.
Fix spaces vs. tabs in all files.
Add IDE settings file to source control.
Remove spaces at end of line (assuming there is an editor option for that in IntelliJ).

Following that, feel free to submit "coding style cleanup" PRs. However, such PRs must not be mixed with any functional changes. We can do few classes at a time.

Coding standards #4

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions