Consolidate overloads of SetPropertyValue()

JeremyCaney · JeremyCaney · commit 13d43d14d378 · 2021-02-02T16:00:01.000-08:00
This reduces the amount of code by consolidating largely repetitive methods. In addition, however, it fixes a bug (? or at least unexpected behavior) where a caller with a generic type that of `string?` doesn't call the `string?` overload but rather the `object?` overload, unless it's explicitly converted to a string first. That's a confusing burden to put on callers, so it's easier to handle here—and especially given that the `MemberDispatcher` will frequently be called either with genetics.
diff --git a/OnTopic/Internal/Reflection/MemberDispatcher.cs b/OnTopic/Internal/Reflection/MemberDispatcher.cs
@@ -137,26 +137,28 @@ internal bool HasSettableProperty(Type type, string name, Type? targetType = nul
     | METHOD: SET PROPERTY VALUE
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Uses reflection to call a property, assuming that it is a) writable, and b) of type <see cref="String"/>,
-    ///   <see cref="Int32"/>, or <see cref="Boolean"/>.
+    ///   Uses reflection to call a property, assuming that it is a) writable, and b) of type <see cref="String"/>, <see cref="
+    ///   Int32"/>, or <see cref="Boolean"/>, or is otherwise compatible with the <paramref name="value"/> type.
     /// </summary>
     /// <param name="target">The object on which the property is defined.</param>
     /// <param name="name">The name of the property to assess.</param>
     /// <param name="value">The value to set on the property.</param>
-    internal bool SetPropertyValue(object target, string name, string? value) {
+    internal bool SetPropertyValue(object target, string name, object? value) {
 
       Contract.Requires(target, nameof(target));
       Contract.Requires(name, nameof(name));
 
-      if (!HasSettableProperty(target.GetType(), name)) {
+      var isString = value?.GetType() == typeof(string);
+
+      if (!HasSettableProperty(target.GetType(), name, isString? null : value?.GetType())) {
         return false;
       }
 
       var property = GetMember<PropertyInfo>(target.GetType(), name);
 
       Contract.Assume(property, $"The {name} property could not be retrieved.");
 
-      var valueObject = GetValueObject(property.PropertyType, value);
+      var valueObject = isString? GetValueObject(property.PropertyType, value as string) : value;
 
       if (valueObject is null) {
         return false;
@@ -167,35 +169,6 @@ internal bool SetPropertyValue(object target, string name, string? value) {
 
     }
 
-    /// <summary>
-    ///   Uses reflection to call a property, assuming that the property value is compatible with the <paramref name="value"/>
-    ///   type.
-    /// </summary>
-    /// <param name="target">The object on which the property is defined.</param>
-    /// <param name="name">The name of the property to assess.</param>
-    /// <param name="value">The value to set on the property.</param>
-    internal bool SetPropertyValue(object target, string name, object? value) {
-
-      Contract.Requires(target, nameof(target));
-      Contract.Requires(name, nameof(name));
-
-      if (!HasSettableProperty(target.GetType(), name, value?.GetType())) {
-        return false;
-      }
-
-      var property = GetMember<PropertyInfo>(target.GetType(), name);
-
-      Contract.Assume(property, $"The {name} property could not be retrieved.");
-
-      if (value is null) {
-        return false;
-      }
-
-      property.SetValue(target, value);
-      return true;
-
-    }
-
     /*==========================================================================================================================
     | METHOD: HAS GETTABLE PROPERTY
     \-------------------------------------------------------------------------------------------------------------------------*/
