Updated ReverseTopicMappingService to use InvalidOperationException

JeremyCaney · JeremyCaney · commit 1f4949592401 · 2020-12-17T15:03:56.000-08:00
Previously, several validators used the `InvalidEnumArgumentException`, which makes sense if validating the argument of e.g. an `Attribute`, but these particular validators aren't doing that. Fell back to the more general `InvalidOperationException`. As these are primarily intended to validate design decisions, they aren't expected to impact any implementations.
diff --git a/OnTopic/Mapping/Reverse/ReverseTopicMappingService.cs b/OnTopic/Mapping/Reverse/ReverseTopicMappingService.cs
@@ -145,17 +145,17 @@ public ReverseTopicMappingService(ITopicRepository topicRepository) {
 
       //Ensure the content type is valid
       if (!_contentTypeDescriptors.Contains(source.ContentType)) {
-        throw new InvalidEnumArgumentException(
+        throw new InvalidOperationException(
           $"The {nameof(source)} object (with the key '{source.Key}') has a content type of '{source.ContentType}'. There " +
-          $"no matching content type in the ITopicRepository provided. This suggests that the binding model is invalid. If " +
-          $"this is expected—e.g., if the content type is being added as part of this operation—then it needs to be added " +
+          $"are no matching content types in the ITopicRepository provided. This suggests that the binding model is invalid. " +
+          $"If this is expected—e.g., if the content type is being added as part of this operation—then it needs to be added " +
           $"to the same ITopicRepository instance prior to creating any instances of it."
         );
       }
 
       //Ensure the content types match
       if (source.ContentType != target.ContentType) {
-        throw new InvalidEnumArgumentException(
+        throw new InvalidOperationException(
           $"The {nameof(source)} object (with the key '{source.Key}') has a content type of '{source.ContentType}', while " +
           $"the {nameof(target)} object (with the key '{source.Key}') has a content type of '{target.ContentType}'. It is not" +
           $"permitted to change the topic's content type during a mapping operation, as this interferes with the validation. " +
@@ -165,7 +165,7 @@ public ReverseTopicMappingService(ITopicRepository topicRepository) {
 
       //Ensure the keys match
       if (source.Key != target.Key && !String.IsNullOrEmpty(source.Key)) {
-        throw new InvalidEnumArgumentException(
+        throw new InvalidOperationException(
           $"The {nameof(source)} object has a key of '{source.Key}', while the {nameof(target)} object has a key of " +
           $"'{target.Key}'. It is not permitted to change the topic'key during a mapping operation, as this suggests in " +
           $"invalid target. If this is by design, change the key on the target topic prior to invoking MapAsync()."
