Merge branch 'bugfix/DeleteOrphanedLastModifiedAttributes' into release/5.1.0

JeremyCaney · JeremyCaney · commit 34084fd970a4 · 2021-04-08T12:30:36.000-07:00
Previously, the `DeleteOrphanedLastModifiedAttributes` only accounted for `LastModified`, not `LastModifiedBy`—and, as such, would not get tripped if both the `LastModified` _and_ `LastModifiedBy` attributes were updated at the same time, even if no other attributes were updated. Further, it didn't account for `TopicReferences` or `Relationships`—which, as of OnTopic 5.0.0, are also versioned. As a result, this would yield a false positive if the `LastModified` and `LastModifiedBy` attributes accompanied a change that only otherwise affected topic associations. The resolves #88.
diff --git a/OnTopic.Data.Sql.Database/Utilities/Stored Procedures/DeleteOrphanedLastModifiedAttributes.sql b/OnTopic.Data.Sql.Database/Utilities/Stored Procedures/DeleteOrphanedLastModifiedAttributes.sql
@@ -37,13 +37,21 @@ FROM	Attributes
 LEFT JOIN	Attributes Unmatched
   ON	Attributes.TopicID = Unmatched.TopicID
   AND	Attributes.Version = Unmatched.Version
-  AND	Attributes.AttributeKey != Unmatched.AttributeKey
+  AND	Unmatched.AttributeKey NOT LIKE 'LastModified%'
 LEFT JOIN	ExtendedAttributes UnmatchedExtended
   ON	Attributes.TopicID = UnmatchedExtended.TopicID
   AND	Attributes.Version = UnmatchedExtended.Version
+LEFT JOIN	Relationships UnmatchedRelationships
+  ON	Attributes.TopicID = UnmatchedRelationships.Source_TopicID
+  AND	Attributes.Version = UnmatchedRelationships.Version
+LEFT JOIN	TopicReferences UnmatchedReferences
+  ON	Attributes.TopicID = UnmatchedReferences.Source_TopicID
+  AND	Attributes.Version = UnmatchedReferences.Version
 WHERE	Unmatched.AttributeKey IS NULL
   AND	UnmatchedExtended.TopicID IS NULL
-  AND	Attributes.AttributeKey = 'LastModified'
+  AND	UnmatchedRelationships.Source_TopicID IS NULL
+  AND	UnmatchedReferences.Source_TopicID IS NULL
+  AND 	Attributes.AttributeKey LIKE 'LastModified%'
 
 --------------------------------------------------------------------------------------------------------------------------------
 -- CHECK FINAL VALUES
