Fixed Topic.FindAll() extension method to use Collection<Topic>

JeremyCaney · JeremyCaney · commit 75f6369d2aca · 2021-01-12T15:52:51.000-08:00
Previously, the `Topic.FindAll()` method was using a `KeyedTopicCollection`, which prevented duplicate keys. We had migrated `Topic.FindAll()` to an `IEnumerable&lt;Topic&gt;` in order to allow duplicates. This remedies that conflict.
diff --git a/OnTopic/Querying/TopicExtensions.cs b/OnTopic/Querying/TopicExtensions.cs
@@ -5,6 +5,7 @@
 \=============================================================================================================================*/
 using System;
 using System.Collections.Generic;
+using System.Collections.ObjectModel;
 using OnTopic.Attributes;
 using OnTopic.Collections;
 using OnTopic.Internal.Diagnostics;
@@ -129,7 +130,7 @@ public static IEnumerable<Topic> FindAll(this Topic topic, Func<Topic, bool> pre
       /*------------------------------------------------------------------------------------------------------------------------
       | Search attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var results = new KeyedTopicCollection();
+      var results = new Collection<Topic>();
 
       if (predicate(topic)) {
         results.Add(topic);
@@ -141,7 +142,7 @@ public static IEnumerable<Topic> FindAll(this Topic topic, Func<Topic, bool> pre
       foreach (var child in topic.Children) {
         var nestedResults = child.FindAll(predicate);
         foreach (var matchedTopic in nestedResults) {
-          if (!results.Contains(matchedTopic.Key)) {
+          if (!results.Contains(matchedTopic)) {
             results.Add(matchedTopic);
           }
         }
