Removed legacy CreateRelationshipsXml() support

JeremyCaney · JeremyCaney · commit 7bea7d320e9e · 2020-05-28T14:42:16.000-07:00
In a previous version of OnTopic, presumably, there was a need to build an XML document out of the relationships, presumably so that they could optionally be stored as part of the XML blob. This hasn't been used for a while, however, and only adds clutter and unnecessary complexity to an already bloated class. Cancelled!
diff --git a/OnTopic.Data.Sql/SqlTopicRepository.cs b/OnTopic.Data.Sql/SqlTopicRepository.cs
@@ -465,7 +465,7 @@ List<Topic> unresolvedRelationships
         );
 
         if (areReferencesResolved && areRelationshipsDirty) {
-          PersistRelations(topic, connection, true);
+          PersistRelations(topic, connection);
         }
 
         topic.VersionHistory.Insert(0, version.Value);
@@ -640,21 +640,14 @@ public override void Delete(Topic topic, bool isRecursive = false) {
     /// </summary>
     /// <param name="topic">The topic object whose relationships should be persisted.</param>
     /// <param name="connection">The SQL connection.</param>
-    /// <param name="skipXml">
-    ///   Boolean indicator noting whether attributes saved in the XML should be skipped as part of the operation.
-    /// </param>
-    /// <returns>
-    ///   An XML-formatted string representing the <see cref="Topic.Relationships"/> XML content, or a blank string if
-    ///   <c>skipXml == true</c>.
-    /// </returns>
-    private static string PersistRelations(Topic topic, SqlConnection connection, bool skipXml) {
+    private static void PersistRelations(Topic topic, SqlConnection connection) {
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Return blank if the topic has no relations.
       \-----------------------------------------------------------------------------------------------------------------------*/
-      // return "" if the topic has no relations
+      // return if the topic has no relations
       if (!topic.Relationships.Keys.Any()) {
-        return "";
+        return;
       }
       var command               = (SqlCommand?)null;
 
@@ -713,51 +706,11 @@ private static string PersistRelations(Topic topic, SqlConnection connection, bo
       }
 
       /*------------------------------------------------------------------------------------------------------------------------
-      | Return the relationship attributes to append to the XML attributes (unless skipXml is set to true)
+      | Return
       \-----------------------------------------------------------------------------------------------------------------------*/
-      return skipXml? "" : CreateRelationshipsXml(topic);
+      return;
 
     }
 
-    /*==========================================================================================================================
-    | METHOD: CREATE RELATIONSHIPS XML
-    \-------------------------------------------------------------------------------------------------------------------------*/
-    /// <summary>
-    ///   Internal helper function to build string of related XML nodes for each scope of related items in model.
-    /// </summary>
-    /// <param name="topic">The topic object for which to create the relationships.</param>
-    /// <returns>The XML string.</returns>
-    private static string CreateRelationshipsXml(Topic topic) {
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Create XML string container
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      var attributesXml         = new StringBuilder("");
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Add a related XML node for each scope
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      foreach (var key in topic.Relationships.Keys) {
-
-        var scope               = topic.Relationships.GetTopics(key);
-
-        attributesXml.Append("<related scope=\"");
-        attributesXml.Append(key);
-        attributesXml.Append("\">");
-
-        // Build out string array of related items in this scope
-        var targetIds           = new string[scope.Count];
-        var count               = 0;
-        foreach (var relTopic in scope) {
-          targetIds[count]      = relTopic.Id.ToString(CultureInfo.InvariantCulture);
-          count++;
-        }
-        attributesXml.Append(String.Join(",", targetIds));
-        attributesXml.Append("</related>");
-      }
-
-      return attributesXml.ToString();
-    }
-
   } //Class
 } //Namespace
