Enforce dropping columns as part of pre-deployment script

JeremyCaney · JeremyCaney · commit b5b4829382d5 · 2020-12-23T16:21:07.000-08:00
Now that we have established a pre-deployment script (1124443) we can use it to address issues not effectively addressed by schema comparison. Notably, schema comparison won't drop columns that have data in them. As such, we can drop the legacy `Topics.Stack_Top` (8ba3514) and `Attributes.DateModified` (2b981f2) columns, which were previously removed from the schema.
diff --git a/OnTopic.Data.Sql.Database/Scripts/Upgrade from OnTopic 4 to OnTopic 5.sql b/OnTopic.Data.Sql.Database/Scripts/Upgrade from OnTopic 4 to OnTopic 5.sql
@@ -5,6 +5,29 @@
 -- prior to running migrations.
 --------------------------------------------------------------------------------------------------------------------------------
 
+--------------------------------------------------------------------------------------------------------------------------------
+-- DROP COLUMNS
+--------------------------------------------------------------------------------------------------------------------------------
+-- Migrations won't drop columns that have data in them. The following drop columns that are no longer needed. This also drops
+-- stored procedures that reference those columns—with the knowledge that their replacements will be recreated by the
+-- migrations.
+--------------------------------------------------------------------------------------------------------------------------------
+
+ALTER
+TABLE	Topics
+DROP
+COLUMN	Stack_Top;
+
+ALTER
+TABLE	Attributes
+DROP
+CONSTRAINT	DF_Attributes_DateModified;
+
+ALTER
+TABLE	Attributes
+DROP
+COLUMN	DateModified;
+
 --------------------------------------------------------------------------------------------------------------------------------
 -- MIGRATE CORE ATTRIBUTES
 --------------------------------------------------------------------------------------------------------------------------------
