Removed virtual from the SitemapController actions

JeremyCaney · JeremyCaney · commit da5e81c601ec · 2021-01-27T12:59:17.000-08:00
In the `SitemapController`, the implementation is so involved that it's unclear how deriving this would satisfy any customization requirements.

If there's a need to customize the business logic—and there may well be!—we'd want to revisit what the extensibility points are, and whether there's a better way of accomodating the need. For instance, there may be a good argument for exposing an options object to the constructor, or a delegate which validates which topics or attributes to include in the index.

For now, however, having the `Index` and `Extended` actions marked as `virtual` doesn't really facilitate those potential requirements.
diff --git a/OnTopic.AspNetCore.Mvc/Controllers/SitemapController.cs b/OnTopic.AspNetCore.Mvc/Controllers/SitemapController.cs
@@ -98,7 +98,7 @@ public SitemapController(ITopicRepository topicRepository) {
     /// <param name="indent">Optionally enables indentation of XML elements in output for human readability.</param>
     /// <param name="includeMetadata">Optionally enables extended metadata associated with each topic.</param>
     /// <returns>A Sitemap.org sitemap.</returns>
-    public virtual ActionResult Index(bool indent = false, bool includeMetadata = false) {
+    public ActionResult Index(bool indent = false, bool includeMetadata = false) {
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Ensure topics are loaded
@@ -138,7 +138,7 @@ public virtual ActionResult Index(bool indent = false, bool includeMetadata = fa
     /// </remarks>
     /// <param name="indent">Optionally enables indentation of XML elements in output for human readability.</param>
     /// <returns>A Sitemap.org sitemap.</returns>
-    public virtual ActionResult Extended(bool indent = false) => Index(indent, true);
+    public ActionResult Extended(bool indent = false) => Index(indent, true);
 
     /*==========================================================================================================================
     | METHOD: GENERATE SITEMAP
