Grouped Save() parameters

JeremyCaney · JeremyCaney · commit e40f433acc5b · 2020-04-17T12:47:32.000-07:00
In practice, the parameters can be set in any order—they needn't map to the order used in the stored procedure(s). This allows us to use more natural grouping.

For instance, instead of checking `isNew` twice, we can just place both `CreateTopic` parameters within a single `isNew` condition.

Also moved `@Attributes` to the end since doesn't use the `AddParameter()` overload and, thus, doesn't align nicely with the other parameters.
diff --git a/OnTopic.Data.Sql/SqlTopicRepository.cs b/OnTopic.Data.Sql/SqlTopicRepository.cs
@@ -341,16 +341,14 @@ public override int Save([NotNull]Topic topic, bool isRecursive = false, bool is
       \-----------------------------------------------------------------------------------------------------------------------*/
       if (!isNew) {
         command.AddParameter("TopicID", topic.Id);
+        command.AddParameter("DeleteRelationships", true);
       }
       else if (topic.Parent != null) {
         command.AddParameter("ParentID", topic.Parent.Id);
       }
-      command.Parameters.AddWithValue("@Attributes", attributes);
-      if (!isNew) {
-        command.AddParameter("DeleteRelationships", true);
-      }
       command.AddParameter("Version", version.Value);
       command.AddParameter("ExtendedAttributes", extendedAttributes);
+      command.Parameters.AddWithValue("@Attributes", attributes);
       command.AddOutputParameter();
 
       /*------------------------------------------------------------------------------------------------------------------------
