Skip to content

Commit ff58a71

Browse files
JeremyCaneyJeremyCaney
committed
Delete legacy GetTopicID function
In a previous update, `SqlTopicRepository` was updated to use the new(er) `GetTopicIDByUniqueKey` function over the legacy `GetTopicID` function, thus operating off the `UniqueKey` instead of just finding the first instance of a key (4c3d30f). More recently, the same was applied to the `GetTopics` stored procedure (5706897). With this, the legacy `GetTopicID` function is no longer needed; the `GetTopicIDByUniqueKey` function should always be used instead. This addresses flakey behavior in `GetTopicID` since it didn't allow callers to specify a unique topic, and could thus lead to bugs.
1 parent a0f1a32 commit ff58a71

2 files changed

Lines changed: 0 additions & 46 deletions

File tree

‎OnTopic.Data.Sql.Database/Functions/GetTopicID.sql‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎OnTopic.Data.Sql.Database/OnTopic.Data.Sql.Database.sqlproj‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@
103103
<Build Include="Views\ExtendedAttributeIndex.sql" />
104104
<Build Include="Views\VersionHistoryIndex.sql" />
105105
<Build Include="Functions\GetParentID.sql" />
106-
<Build Include="Functions\GetTopicID.sql" />
107106
<Build Include="Stored Procedures\MoveTopic.sql" />
108107
<Build Include="Stored Procedures\UpdateTopic.sql" />
109108
<Build Include="Stored Procedures\UpdateRelationships.sql" />

0 commit comments

Comments
 (0)