-
Notifications
You must be signed in to change notification settings - Fork 2
ReverseTopicMappingService: Overwrite Topic References #42
Copy link
Copy link
Closed
Labels
Area: MappingRelates to one of the `ITopicMappingService` interfaces or implementations.Relates to one of the `ITopicMappingService` interfaces or implementations.Priority: 3Severity 1: MinorStatus 5: CompleteTask is considered complete, and ready for deployment.Task is considered complete, and ready for deployment.Type: ImprovementImproves the functionality or interface of an existing feature.Improves the functionality or interface of an existing feature.
Milestone
Metadata
Metadata
Assignees
Labels
Area: MappingRelates to one of the `ITopicMappingService` interfaces or implementations.Relates to one of the `ITopicMappingService` interfaces or implementations.Priority: 3Severity 1: MinorStatus 5: CompleteTask is considered complete, and ready for deployment.Task is considered complete, and ready for deployment.Type: ImprovementImproves the functionality or interface of an existing feature.Improves the functionality or interface of an existing feature.
Currently, the
ReverseTopicMappingServicewill bypass anyIAssociatedTopicBindingModelinstances whoseUniqueKeyisnullorempty. But if aUniqueKeyis empty, that should be used to delete any existing topic references that have the sameKey. That's how attributes work in theReverseTopicMappingService*, but not topic references. This isn't necessarily a bug, but it's definitely an unintuitive and unnecessary limitation that should be resolved.The relevant code is within the
SetReference()method of theReverseTopicMappingService.* At least assuming the attribute isn’t backed by a property which requires enforcement of business logic (#65).