-
Notifications
You must be signed in to change notification settings - Fork 2
Sitemap: Exclude Private or System Branches #72
Copy link
Copy link
Closed
Labels
Area: WebRelates to the `AspNetCore` or other web-related functionality.Relates to the `AspNetCore` or other web-related functionality.Priority: 2Severity 1: MinorStatus 5: CompleteTask is considered complete, and ready for deployment.Task is considered complete, and ready for deployment.Type: ImprovementImproves the functionality or interface of an existing feature.Improves the functionality or interface of an existing feature.
Milestone
Metadata
Metadata
Assignees
Labels
Area: WebRelates to the `AspNetCore` or other web-related functionality.Relates to the `AspNetCore` or other web-related functionality.Priority: 2Severity 1: MinorStatus 5: CompleteTask is considered complete, and ready for deployment.Task is considered complete, and ready for deployment.Type: ImprovementImproves the functionality or interface of an existing feature.Improves the functionality or interface of an existing feature.
Currently, all topics are exposed to the
SitemapControllerunless they are explicitly excluded by adding the rootContentTypeto theExcludedContentTypeslist or marking aContainerasNoIndex. As identified in #38, however, this isn't an entirely satisfactory approach, however, for two reasons (reference):Container, andNoIndexnomenclature is ambiguous with theNoIndexused onPage, which is not recursive.To mitigate this, ideally, we'll find a different way to establish a non-ambiguous, universal nomenclature for excluding entire branches from the sitemap.
Options
NoIndexorNoIndexBranchIsSystemorIsSystemBranchIsPrivateorIsPrivateBranchMetatag
Should this be exposed to
TopicViewModel? This would allow child pages to include thenoindexmetatag in their HTML headers. Mapping inherited attributes is more expensive than mapping normal attributes, however, and especially for a property that we don't normally expect to be defined. For that reason, this may make more sense to be used exclusively for branches that we don't expect to be exposed to be exposed as web pages. In that case,IsSystem(Branch)orIsPrivate(Branch)better distinguishes this behavior from the metatag.