Remove unnecessary finalizers (#14248)

xtqqczze · web-flow · commit 15e4e8a6af2f · 2020-11-24T12:30:42.000-08:00
diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/ContentCommandBase.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/ContentCommandBase.cs
@@ -705,14 +705,6 @@ public void Dispose()
             GC.SuppressFinalize(this);
         }
 
-        /// <summary>
-        /// Finalizer.
-        /// </summary>
-        ~ContentCommandBase()
-        {
-            Dispose(false);
-        }
         #endregion IDisposable
-
     }
 }
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutGridViewCommand.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutGridViewCommand.cs
@@ -492,13 +492,5 @@ public void Dispose()
             this.Dispose(true);
             GC.SuppressFinalize(this);
         }
-
-        /// <summary>
-        /// Finalizer.
-        /// </summary>
-        ~OutGridViewCommand()
-        {
-            Dispose(false);
-        }
     }
 }
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs
@@ -63,14 +63,6 @@ public class ShowCommandCommand : PSCmdlet, IDisposable
         private object _commandViewModelObj;
         #endregion
 
-        /// <summary>
-        /// Finalizes an instance of the ShowCommandCommand class.
-        /// </summary>
-        ~ShowCommandCommand()
-        {
-            this.Dispose(false);
-        }
-
         #region Input Cmdlet Parameter
         /// <summary>
         /// Gets or sets the command name.
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs
@@ -149,14 +149,6 @@ public void Dispose()
             GC.SuppressFinalize(this);
         }
 
-        /// <summary>
-        /// Finalizer.
-        /// </summary>
-        ~TeeObjectCommand()
-        {
-            Dispose(false);
-        }
-
         #region private
         private CommandWrapper _commandWrapper;
         private bool _alreadyDisposed;
diff --git a/src/System.Management.Automation/engine/CommandProcessorBase.cs b/src/System.Management.Automation/engine/CommandProcessorBase.cs
@@ -957,14 +957,6 @@ private void Dispose(bool disposing)
             _disposed = true;
         }
 
-        /// <summary>
-        /// Finalizer for class CommandProcessorBase.
-        /// </summary>
-        ~CommandProcessorBase()
-        {
-            Dispose(false);
-        }
-
         #endregion IDispose
     }
 }
diff --git a/src/System.Management.Automation/engine/EventManager.cs b/src/System.Management.Automation/engine/EventManager.cs
@@ -1510,14 +1510,6 @@ protected virtual void OnForwardEvent(PSEventArgs e)
             ForwardEvent?.Invoke(this, e);
         }
 
-        /// <summary>
-        /// Destructor for the EventManager class.
-        /// </summary>
-        ~PSLocalEventManager()
-        {
-            Dispose(false);
-        }
-
         /// <summary>
         /// Disposes the EventManager class.
         /// </summary>
diff --git a/src/System.Management.Automation/engine/lang/scriptblock.cs b/src/System.Management.Automation/engine/lang/scriptblock.cs
@@ -1313,14 +1313,6 @@ private void Dispose(bool disposing)
             _disposed = true;
         }
 
-        /// <summary>
-        /// Finalizer for class SteppablePipeline.
-        /// </summary>
-        ~SteppablePipeline()
-        {
-            Dispose(false);
-        }
-
         #endregion IDispose
     }
 
diff --git a/src/System.Management.Automation/engine/pipeline.cs b/src/System.Management.Automation/engine/pipeline.cs
@@ -91,14 +91,6 @@ private void Dispose(bool disposing)
             _disposed = true;
         }
 
-        /// <summary>
-        /// Finalizer for class PipelineProcessor.
-        /// </summary>
-        ~PipelineProcessor()
-        {
-            Dispose(false);
-        }
-
         #endregion IDispose
 
         #region Execution Logging

Original file line number	Diff line number	Diff line change
`@@ -705,14 +705,6 @@ public void Dispose()`
`705`	`705`	`GC.SuppressFinalize(this);`
`706`	`706`	`}`
`707`	`707`
`708`		`- /// <summary>`
`709`		`- /// Finalizer.`
`710`		`- /// </summary>`
`711`		`- ~ContentCommandBase()`
`712`		`- {`
`713`		`- Dispose(false);`
`714`		`- }`
`715`	`708`	`#endregion IDisposable`
`716`		`-`
`717`	`709`	`}`
`718`	`710`	`}`
Original file line number	Diff line number	Diff line change
`@@ -492,13 +492,5 @@ public void Dispose()`
`492`	`492`	`this.Dispose(true);`
`493`	`493`	`GC.SuppressFinalize(this);`
`494`	`494`	`}`
`495`		`-`
`496`		`- /// <summary>`
`497`		`- /// Finalizer.`
`498`		`- /// </summary>`
`499`		`- ~OutGridViewCommand()`
`500`		`- {`
`501`		`- Dispose(false);`
`502`		`- }`
`503`	`495`	`}`
`504`	`496`	`}`
Original file line number	Diff line number	Diff line change
`@@ -957,14 +957,6 @@ private void Dispose(bool disposing)`
`957`	`957`	`_disposed = true;`
`958`	`958`	`}`
`959`	`959`
`960`		`- /// <summary>`
`961`		`- /// Finalizer for class CommandProcessorBase.`
`962`		`- /// </summary>`
`963`		`- ~CommandProcessorBase()`
`964`		`- {`
`965`		`- Dispose(false);`
`966`		`- }`
`967`		`-`
`968`	`960`	`#endregion IDispose`
`969`	`961`	`}`
`970`	`962`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1313,14 +1313,6 @@ private void Dispose(bool disposing)`
`1313`	`1313`	`_disposed = true;`
`1314`	`1314`	`}`
`1315`	`1315`
`1316`		`- /// <summary>`
`1317`		`- /// Finalizer for class SteppablePipeline.`
`1318`		`- /// </summary>`
`1319`		`- ~SteppablePipeline()`
`1320`		`- {`
`1321`		`- Dispose(false);`
`1322`		`- }`
`1323`		`-`
`1324`	`1316`	`#endregion IDispose`
`1325`	`1317`	`}`
`1326`	`1318`